2017-11-08 21:31:42

by Bryant G. Ly

[permalink] [raw]
Subject: Re: [PATCH 3/6] target: Fix quiese during transport_write_pending_qf endless loop


> From: Nicholas Bellinger <[email protected]>
>
> This patch fixes a potential end-less loop during QUEUE_FULL,
> where cmd->se_tfo->write_pending() callback fails repeatedly
> but __transport_wait_for_tasks() has already been invoked to
> quiese the outstanding se_cmd descriptor.
>
> To address this bug, this patch adds a CMD_T_STOP|CMD_T_ABORTED
> check within transport_write_pending_qf() and invokes the
> existing se_cmd->t_transport_stop_comp to signal quiese
> completion back to __transport_wait_for_tasks().
>
> Cc: Mike Christie <[email protected]>
> Cc: Hannes Reinecke <[email protected]>
> Cc: Bryant G. Ly <[email protected]>
> Cc: Michael Cyr <[email protected]>
> Cc: Potnuri Bharat Teja <[email protected]>
> Cc: Sagi Grimberg <[email protected]>
> Signed-off-by: Nicholas Bellinger <[email protected]>
> ---
>
Reviewed-by: Bryant G. Ly <[email protected]>



From 1583471143734724398@xxx Wed Nov 08 04:36:00 +0000 2017
X-GM-THRID: 1583471143734724398
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread