2009-07-01 19:19:17

by Chris Verges

[permalink] [raw]
Subject: RE: [lm-sensors] [PATCH] adxl345 accelerometer hwmon driver

Hi Jonathan,

Thanks for the response!

> Just for reference this chip is definitely on my list of ones to
support
> via the Industrial I/O (iio) framework, I just haven't managed to get
hold
> of one as yet!

If you need a sample set, let me know off the mailing list. I may be
able
to ship a couple to you ... need to check our available stock. I think
ours are BGAs, in case you have the intention of soldering by hand. :-)

> What are you actually doing with it? If you aren't doing hardware
> monitoring then I would expect you aren't going to receive a
favourable
> response on here.

The ADXL345 is a 3D accelerometer. It's very similar to the following
chips already in the HWMON section of the kernel:

- SENSORS_LIS3LV02D
- SENSORS_APPLESMC

The driver provides 3D axis data when the user polls the chip via the
sysfs
interface.

The ADXL345 has the additional capability of being a "tap-touch"
detector --
almost like an input device, if you will -- but this driver doesn't
expose
that functionality. Maybe in the future.

> I'll take a look at the actual code tomorrow. Always good to see
another
> accelerometer driver.

Thanks! Looking forward to the feedback.

Chris


2009-07-01 20:13:26

by Jean Delvare

[permalink] [raw]
Subject: Re: [PATCH] adxl345 accelerometer hwmon driver

On Wed, 1 Jul 2009 12:19:02 -0700, Chris Verges wrote:
> > What are you actually doing with it? If you aren't doing hardware
> > monitoring then I would expect you aren't going to receive a
> > favourable response on here.
>
> The ADXL345 is a 3D accelerometer. It's very similar to the following
> chips already in the HWMON section of the kernel:
>
> - SENSORS_LIS3LV02D
> - SENSORS_APPLESMC
>
> The driver provides 3D axis data when the user polls the chip via the
> sysfsinterface.

A few accelerometer drivers were originally added to drivers/hwmon
because the chips also included some hwmon features (e.g. temperature
sensor.) Now every new accelerometer driver gets dropped in
drivers/hwmon "because there are other accelerometer drivers there".
The LIS3LV02D driver is a perfect example of this... the device is not
even registered as a hwmon driver! This driver definitely doesn't
belong there.

Probably it's about time to put an end to this and kick all
accelerometer drivers out of drivers/hwmon.

--
Jean Delvare

2009-07-02 08:05:38

by Éric Piel

[permalink] [raw]
Subject: Re: [PATCH] adxl345 accelerometer hwmon driver

Op 01-07-09 22:13, Jean Delvare schreef:
> A few accelerometer drivers were originally added to drivers/hwmon
> because the chips also included some hwmon features (e.g. temperature
> sensor.) Now every new accelerometer driver gets dropped in
> drivers/hwmon "because there are other accelerometer drivers there".
> The LIS3LV02D driver is a perfect example of this... the device is not
> even registered as a hwmon driver! This driver definitely doesn't
> belong there.
>
> Probably it's about time to put an end to this and kick all
> accelerometer drivers out of drivers/hwmon.
(I'm the maintainer of LIS3LV02D)
I completely agree with you, accelerometer drivers do not belong to
hwmon. Unfortunately, so far there has not been any landing place which
looked really more relevant. As soon as such a thing is available (maybe
an "accelerometer" subsystem) I'll be happy to move the driver :-)

Eric



Attachments:
E_A_B_Piel.vcf (367.00 B)