2023-03-27 20:26:52

by Ivan Orlov

Subject: [PATCH v2] selftests: sched: Add more core schedule prctl calls

The core sched kselftest makes prctl calls only with correct
parameters. This patch will extend this test with more core
schedule prctl calls with wrong parameters to increase code
coverage.

Signed-off-by: Ivan Orlov <[email protected]>
---
V1 -> V2: Unnecessary printing removed - 'validate' will
automatically print the message in case or error

tools/testing/selftests/sched/cs_prctl_test.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/tools/testing/selftests/sched/cs_prctl_test.c b/tools/testing/selftests/sched/cs_prctl_test.c
index 25e0d95d3713..3e1619b6bf2d 100644
--- a/tools/testing/selftests/sched/cs_prctl_test.c
+++ b/tools/testing/selftests/sched/cs_prctl_test.c
@@ -334,6 +334,12 @@ int main(int argc, char *argv[])
validate(get_cs_cookie(pid) != 0);
validate(get_cs_cookie(pid) == get_cs_cookie(procs[pidx].thr_tids[0]));

+ validate(_prctl(PR_SCHED_CORE, PR_SCHED_CORE_MAX, 0, PIDTYPE_PGID, 0) < 0
+ && errno == EINVAL);
+
+ validate(_prctl(PR_SCHED_CORE, PR_SCHED_CORE_SHARE_TO, 0, PIDTYPE_PGID, 1) < 0
+ && errno == EINVAL);
+
if (errors) {
printf("TESTS FAILED. errors: %d\n", errors);
res = 10;
--
2.34.1

2023-03-28 16:41:36

by Shuah Khan

Subject: Re: [PATCH v2] selftests: sched: Add more core schedule prctl calls

On 3/27/23 14:18, Ivan Orlov wrote:
> The core sched kselftest makes prctl calls only with correct
> parameters. This patch will extend this test with more core
> schedule prctl calls with wrong parameters to increase code
> coverage.
>
> Signed-off-by: Ivan Orlov <[email protected]>
> ---
> V1 -> V2: Unnecessary printing removed - 'validate' will
> automatically print the message in case or error
>

Thank you. Now applied to linux-kselftest next for Linux 6.4-rc1.

thanks,
-- Shuah