2021-11-10 00:52:19

by Angus Ainslie

[permalink] [raw]

Subject: [PATCH] power: bq25890: temperature is also an adc value

---

Make sure that a conversion is forced when the power supply is offline so
the temperature is valid.

Signed-off-by: Angus Ainslie <[email protected]>
---
drivers/power/supply/bq25890_charger.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
index 945c3257ca93..23a91c5d1f9d 100644
--- a/drivers/power/supply/bq25890_charger.c
+++ b/drivers/power/supply/bq25890_charger.c
@@ -388,6 +388,7 @@ static bool bq25890_is_adc_property(enum power_supply_property psp)
switch (psp) {
case POWER_SUPPLY_PROP_VOLTAGE_NOW:
case POWER_SUPPLY_PROP_CURRENT_NOW:
+ case POWER_SUPPLY_PROP_TEMP:
return true;

default:
--
2.25.1

2021-11-15 15:23:03

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power: bq25890: temperature is also an adc value

---

Hi,

On Tue, Nov 09, 2021 at 04:24:40PM -0800, Angus Ainslie wrote:
> Make sure that a conversion is forced when the power supply is offline so
> the temperature is valid.
>
> Signed-off-by: Angus Ainslie <[email protected]>
> ---

Thanks, queued to power-supply's fixes branch.

-- Sebastian

> drivers/power/supply/bq25890_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
> index 945c3257ca93..23a91c5d1f9d 100644
> --- a/drivers/power/supply/bq25890_charger.c
> +++ b/drivers/power/supply/bq25890_charger.c
> @@ -388,6 +388,7 @@ static bool bq25890_is_adc_property(enum power_supply_property psp)
> switch (psp) {
> case POWER_SUPPLY_PROP_VOLTAGE_NOW:
> case POWER_SUPPLY_PROP_CURRENT_NOW:
> + case POWER_SUPPLY_PROP_TEMP:
> return true;
>
> default:
> --
> 2.25.1
>

---

Attachments:

(No filename) (883.00 B)
signature.asc (833.00 B)
Download all attachments

2021-11-15 15:48:48

by Angus Ainslie

[permalink] [raw]

Subject: Re: [PATCH] power: bq25890: temperature is also an adc value

---

On 2021-11-15 07:22, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Nov 09, 2021 at 04:24:40PM -0800, Angus Ainslie wrote:
>> Make sure that a conversion is forced when the power supply is offline
>> so
>> the temperature is valid.
>>
>> Signed-off-by: Angus Ainslie <[email protected]>
>> ---
>
> Thanks, queued to power-supply's fixes branch.
>
> -- Sebastian
>

Thanks !

Angus

>> drivers/power/supply/bq25890_charger.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/power/supply/bq25890_charger.c
>> b/drivers/power/supply/bq25890_charger.c
>> index 945c3257ca93..23a91c5d1f9d 100644
>> --- a/drivers/power/supply/bq25890_charger.c
>> +++ b/drivers/power/supply/bq25890_charger.c
>> @@ -388,6 +388,7 @@ static bool bq25890_is_adc_property(enum
>> power_supply_property psp)
>> switch (psp) {
>> case POWER_SUPPLY_PROP_VOLTAGE_NOW:
>> case POWER_SUPPLY_PROP_CURRENT_NOW:
>> + case POWER_SUPPLY_PROP_TEMP:
>> return true;
>>
>> default:
>> --
>> 2.25.1
>>