2016-04-15 12:11:15

by Crestez Dan Leonard

[permalink] [raw]
Subject: [PATCH] spi: dln2: Pass of_node to spi master

This allows defining SPI devices connected to a DLN2 using devicetree.

This already works for i2c because of a similar patch:
3b10db23: i2c: dln2: set the device tree node of the adapter

Signed-off-by: Crestez Dan Leonard <[email protected]>
---
drivers/spi/spi-dln2.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/spi/spi-dln2.c b/drivers/spi/spi-dln2.c
index 3b7d91d..4e8a862 100644
--- a/drivers/spi/spi-dln2.c
+++ b/drivers/spi/spi-dln2.c
@@ -683,6 +683,7 @@ static int dln2_spi_probe(struct platform_device *pdev)
struct spi_master *master;
struct dln2_spi *dln2;
struct dln2_platform_data *pdata = dev_get_platdata(&pdev->dev);
+ struct device *dev = &pdev->dev;
int ret;

master = spi_alloc_master(&pdev->dev, sizeof(*dln2));
@@ -700,6 +701,8 @@ static int dln2_spi_probe(struct platform_device *pdev)
}

dln2->master = master;
+ dln2->master->dev.parent = dev;
+ dln2->master->dev.of_node = dev->of_node;
dln2->pdev = pdev;
dln2->port = pdata->port;
/* cs/mode can never be 0xff, so the first transfer will set them */
--
2.5.5


2016-04-15 12:19:50

by Laurentiu Palcu

[permalink] [raw]
Subject: Re: [PATCH] spi: dln2: Pass of_node to spi master

On Fri, Apr 15, 2016 at 03:10:52PM +0300, Crestez Dan Leonard wrote:
> This allows defining SPI devices connected to a DLN2 using devicetree.
>
> This already works for i2c because of a similar patch:
> 3b10db23: i2c: dln2: set the device tree node of the adapter
>
> Signed-off-by: Crestez Dan Leonard <[email protected]>
Signed-off-by: Laurentiu Palcu <[email protected]>

> ---
> drivers/spi/spi-dln2.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/spi/spi-dln2.c b/drivers/spi/spi-dln2.c
> index 3b7d91d..4e8a862 100644
> --- a/drivers/spi/spi-dln2.c
> +++ b/drivers/spi/spi-dln2.c
> @@ -683,6 +683,7 @@ static int dln2_spi_probe(struct platform_device *pdev)
> struct spi_master *master;
> struct dln2_spi *dln2;
> struct dln2_platform_data *pdata = dev_get_platdata(&pdev->dev);
> + struct device *dev = &pdev->dev;
> int ret;
>
> master = spi_alloc_master(&pdev->dev, sizeof(*dln2));
> @@ -700,6 +701,8 @@ static int dln2_spi_probe(struct platform_device *pdev)
> }
>
> dln2->master = master;
> + dln2->master->dev.parent = dev;
> + dln2->master->dev.of_node = dev->of_node;
> dln2->pdev = pdev;
> dln2->port = pdata->port;
> /* cs/mode can never be 0xff, so the first transfer will set them */
> --
> 2.5.5
>

2016-04-15 17:02:36

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] spi: dln2: Pass of_node to spi master

On Fri, Apr 15, 2016 at 03:19:35PM +0300, Laurentiu Palcu wrote:
> On Fri, Apr 15, 2016 at 03:10:52PM +0300, Crestez Dan Leonard wrote:

> > Signed-off-by: Crestez Dan Leonard <[email protected]>
> Signed-off-by: Laurentiu Palcu <[email protected]>

Signed-off-by has a specific meaning regarding ownership of patches and
validity of contribution, see SubmittingPatches - I'll take this as an
Acked-by.


Attachments:
(No filename) (419.00 B)
signature.asc (473.00 B)
Download all attachments

2016-04-18 13:11:23

by Mark Brown

[permalink] [raw]
Subject: Applied "spi: dln2: Pass of_node to spi master" to the spi tree

The patch

spi: dln2: Pass of_node to spi master

has been applied to the spi tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 83835fb07836eac1b35e98b919bf757ff7f77aad Mon Sep 17 00:00:00 2001
From: Crestez Dan Leonard <[email protected]>
Date: Fri, 15 Apr 2016 15:10:52 +0300
Subject: [PATCH] spi: dln2: Pass of_node to spi master

This allows defining SPI devices connected to a DLN2 using devicetree.

This already works for i2c because of a similar patch:
3b10db23: i2c: dln2: set the device tree node of the adapter

Signed-off-by: Crestez Dan Leonard <[email protected]>
Acked-by: Laurentiu Palcu <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
---
drivers/spi/spi-dln2.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/spi/spi-dln2.c b/drivers/spi/spi-dln2.c
index 3b7d91d94fea..4e8a8629d514 100644
--- a/drivers/spi/spi-dln2.c
+++ b/drivers/spi/spi-dln2.c
@@ -683,6 +683,7 @@ static int dln2_spi_probe(struct platform_device *pdev)
struct spi_master *master;
struct dln2_spi *dln2;
struct dln2_platform_data *pdata = dev_get_platdata(&pdev->dev);
+ struct device *dev = &pdev->dev;
int ret;

master = spi_alloc_master(&pdev->dev, sizeof(*dln2));
@@ -700,6 +701,8 @@ static int dln2_spi_probe(struct platform_device *pdev)
}

dln2->master = master;
+ dln2->master->dev.parent = dev;
+ dln2->master->dev.of_node = dev->of_node;
dln2->pdev = pdev;
dln2->port = pdata->port;
/* cs/mode can never be 0xff, so the first transfer will set them */
--
2.8.0.rc3