2021-01-12 13:01:04

by Bhaskar Chowdhury

Subject: [PATCH V3] arch: x86: kernel: cpu: Takes a letter away and append a colon to match below stuc member

s/kernlfs/kernfs/
s/@mon_data_kn/@mon_data_kn:/

Signed-off-by: Bhaskar Chowdhury <[email protected]>
---
Changes from V2: Modified the subject line to match exact change description

arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index ee71c47844cb..ef9e2c0809b8 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -142,7 +142,7 @@ enum rdtgrp_mode {

/**
* struct mongroup - store mon group's data in resctrl fs.
- * @mon_data_kn kernlfs node for the mon_data directory
+ * @mon_data_kn: kernfs node for the mon_data directory
* @parent: parent rdtgrp
* @crdtgrp_list: child rdtgroup node list
* @rmid: rmid for this rdtgroup
--
2.26.2

2021-01-12 16:45:36

by Reinette Chatre

Subject: Re: [PATCH V3] arch: x86: kernel: cpu: Takes a letter away and append a colon to match below stuc member

Hi Bhaskar,

Thank you for fixing this.

Could you please fix the subject line to:
1) have correct prefix of "x86/resctrl:". You can see the custom by
running "git log arch/x86/kernel/cpu/resctrl".
2) fix the typo: stuc -> struct

On 1/12/2021 3:01 AM, Bhaskar Chowdhury wrote:
> s/kernlfs/kernfs/
> s/@mon_data_kn/@mon_data_kn:/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>
> ---
> Changes from V2: Modified the subject line to match exact change description
>
> arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index ee71c47844cb..ef9e2c0809b8 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -142,7 +142,7 @@ enum rdtgrp_mode {
>
> /**
> * struct mongroup - store mon group's data in resctrl fs.
> - * @mon_data_kn kernlfs node for the mon_data directory
> + * @mon_data_kn: kernfs node for the mon_data directory
> * @parent: parent rdtgrp
> * @crdtgrp_list: child rdtgroup node list
> * @rmid: rmid for this rdtgroup
> --
> 2.26.2
>

Thank you

Reinette