2023-06-16 12:26:56

by Juerg Haefliger

Subject: [PATCH] media: s5k5baf: Add MODULE_FIRMWARE macro

The module loads firmware so add a MODULE_FIRMWARE macro to provide that
information via modinfo.

Signed-off-by: Juerg Haefliger <[email protected]>
---
drivers/media/i2c/s5k5baf.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c
index 960fbf6428ea..69a3bad54530 100644
--- a/drivers/media/i2c/s5k5baf.c
+++ b/drivers/media/i2c/s5k5baf.c
@@ -2031,3 +2031,5 @@ module_i2c_driver(s5k5baf_i2c_driver);
MODULE_DESCRIPTION("Samsung S5K5BAF(X) UXGA camera driver");
MODULE_AUTHOR("Andrzej Hajda <[email protected]>");
MODULE_LICENSE("GPL v2");
+
+MODULE_FIRMWARE(S5K5BAF_FW_FILENAME);
--
2.37.2

2023-06-16 16:01:20

by Andrzej Hajda

Subject: Re: [PATCH] media: s5k5baf: Add MODULE_FIRMWARE macro

On 16.06.2023 14:01, Juerg Haefliger wrote:
> The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> information via modinfo.
>
> Signed-off-by: Juerg Haefliger <[email protected]>

Acked-by: Andrzej Hajda <[email protected]>

Regards
Andrzej
> ---
> drivers/media/i2c/s5k5baf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c
> index 960fbf6428ea..69a3bad54530 100644
> --- a/drivers/media/i2c/s5k5baf.c
> +++ b/drivers/media/i2c/s5k5baf.c
> @@ -2031,3 +2031,5 @@ module_i2c_driver(s5k5baf_i2c_driver);
> MODULE_DESCRIPTION("Samsung S5K5BAF(X) UXGA camera driver");
> MODULE_AUTHOR("Andrzej Hajda <[email protected]>");
> MODULE_LICENSE("GPL v2");
> +
> +MODULE_FIRMWARE(S5K5BAF_FW_FILENAME);