2020-01-23 14:35:11

by Brahadambal Srinivasan

[permalink] [raw]
Subject: [PATCH] Correction to manpage of cpupower

From: Brahadambal Srinivasan <[email protected]>

Manpage of cpupower is listing wrong sub-commands in "See Also"
section. The option for cpupower-idle(1) should actually be
cpupower-idle-info(1) and cpupower-idle-set(1). This patch corrects
this anomaly.

Signed-off-by: Brahadambal Srinivasan <[email protected]>
---
tools/power/cpupower/man/cpupower.1 | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/power/cpupower/man/cpupower.1 b/tools/power/cpupower/man/cpupower.1
index baf741d06e82..bdbf089794c7 100644
--- a/tools/power/cpupower/man/cpupower.1
+++ b/tools/power/cpupower/man/cpupower.1
@@ -62,9 +62,9 @@ all cores
Print the package name and version number.

.SH "SEE ALSO"
-cpupower-set(1), cpupower-info(1), cpupower-idle(1),
-cpupower-frequency-set(1), cpupower-frequency-info(1), cpupower-monitor(1),
-powertop(1)
+cpupower-set(1), cpupower-info(1), cpupower-idle-info(1),
+cpupower-idle-set(1), cpupower-frequency-set(1), cpupower-frequency-info(1),
+cpupower-monitor(1), powertop(1)
.PP
.SH AUTHORS
.nf
--
2.19.1


2020-01-27 15:52:00

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH] Correction to manpage of cpupower

On 1/23/20 7:33 AM, [email protected] wrote:
> From: Brahadambal Srinivasan <[email protected]>
>
> Manpage of cpupower is listing wrong sub-commands in "See Also"
> section. The option for cpupower-idle(1) should actually be
> cpupower-idle-info(1) and cpupower-idle-set(1). This patch corrects
> this anomaly.
>
> Signed-off-by: Brahadambal Srinivasan <[email protected]>
> ---
> tools/power/cpupower/man/cpupower.1 | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/power/cpupower/man/cpupower.1 b/tools/power/cpupower/man/cpupower.1
> index baf741d06e82..bdbf089794c7 100644
> --- a/tools/power/cpupower/man/cpupower.1
> +++ b/tools/power/cpupower/man/cpupower.1
> @@ -62,9 +62,9 @@ all cores
> Print the package name and version number.
>
> .SH "SEE ALSO"
> -cpupower-set(1), cpupower-info(1), cpupower-idle(1),
> -cpupower-frequency-set(1), cpupower-frequency-info(1), cpupower-monitor(1),
> -powertop(1)
> +cpupower-set(1), cpupower-info(1), cpupower-idle-info(1),
> +cpupower-idle-set(1), cpupower-frequency-set(1), cpupower-frequency-info(1),
> +cpupower-monitor(1), powertop(1)
> .PP
> .SH AUTHORS
> .nf
>

Thanks for fixing this. Applied to

git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git cpupower

for 5.6-rc1 or rc2 pull request to pm maintainer Rafael Wysocki

Please remember to run checkpatch before sending patches in the future
I fixed up minor white space errors in this patch before applying it.

Please run get_maintainers as well to get the complete list of
recipients in the future.

thanks,
-- Shuah