Add D CAN nodes to 66AK2G based SoC dtsi.
Franklin S Cooper Jr (2):
dt-bindings: net: c_can: Update binding for clock and power-domains
property
ARM: configs: keystone: Enable D_CAN driver
Lokesh Vutla (1):
ARM: dts: k2g: Add DCAN nodes
Documentation/devicetree/bindings/net/can/c_can.txt | 13 ++++++++++++-
arch/arm/boot/dts/keystone-k2g.dtsi | 18 ++++++++++++++++++
arch/arm/configs/keystone_defconfig | 3 +++
3 files changed, 33 insertions(+), 1 deletion(-)
--
2.9.4.dirty
CAN driver uses the clk_get_rate call to determine the frequency of the
functional clock. OMAP based SoCs do not require the clock property since
hwmod already handles creating a "fck" clock thats accessible to drivers.
However, this isn't the case for 66AK2G which makes the clocks property
require for that SoC.
66AK2G requires a new property. Therefore, update the binding to also make
this property requirement clear. Also clarify that for OMAP based SoCs
ti,hwmod is a required property.
Signed-off-by: Franklin S Cooper Jr <[email protected]>
---
Documentation/devicetree/bindings/net/can/c_can.txt | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/can/c_can.txt b/Documentation/devicetree/bindings/net/can/c_can.txt
index 5a1d8b0..2d50425 100644
--- a/Documentation/devicetree/bindings/net/can/c_can.txt
+++ b/Documentation/devicetree/bindings/net/can/c_can.txt
@@ -11,9 +11,20 @@ Required properties:
- interrupts : property with a value describing the interrupt
number
-Optional properties:
+The following are mandatory properties for DRA7x, AM33xx and AM43xx SoCs only:
- ti,hwmods : Must be "d_can<n>" or "c_can<n>", n being the
instance number
+
+The following are mandatory properties for Keystone 2 66AK2G SoCs only:
+- power-domains : Should contain a phandle to a PM domain provider node
+ and an args specifier containing the DCAN device id
+ value. This property is as per the binding,
+ Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt
+- clocks : CAN functional clock phandle. This property is as per the
+ binding,
+ Documentation/devicetree/bindings/clock/ti,sci-clk.txt
+
+Optional properties:
- syscon-raminit : Handle to system control region that contains the
RAMINIT register, register offset to the RAMINIT
register and the CAN instance number (0 offset).
--
2.9.4.dirty
From: Lokesh Vutla <[email protected]>
Add nodes for the two DCAN instances included in 66AK2G
Signed-off-by: Lokesh Vutla <[email protected]>
[[email protected]: add power-domains and clock information]
Signed-off-by: Dave Gerlach <[email protected]>
[[email protected]: update subject and commit message. Misc minor updates]
Signed-off-by: Franklin S Cooper Jr <[email protected]>
---
arch/arm/boot/dts/keystone-k2g.dtsi | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index bf4d1fa..bebc857 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -113,6 +113,24 @@
status = "disabled";
};
+ dcan0: can@0260B200 {
+ compatible = "ti,am4372-d_can", "ti,am3352-d_can";
+ reg = <0x0260B200 0x200>;
+ interrupts = <GIC_SPI 190 IRQ_TYPE_EDGE_RISING>;
+ status = "disabled";
+ power-domains = <&k2g_pds 0x0008>;
+ clocks = <&k2g_clks 0x0008 1>;
+ };
+
+ dcan1: can@0260B400 {
+ compatible = "ti,am4372-d_can", "ti,am3352-d_can";
+ reg = <0x0260B400 0x200>;
+ interrupts = <GIC_SPI 193 IRQ_TYPE_EDGE_RISING>;
+ status = "disabled";
+ power-domains = <&k2g_pds 0x0009>;
+ clocks = <&k2g_clks 0x0009 1>;
+ };
+
kirq0: keystone_irq@026202a0 {
compatible = "ti,keystone-irq";
interrupts = <GIC_SPI 1 IRQ_TYPE_EDGE_RISING>;
--
2.9.4.dirty
Enable C_CAN/D_CAN driver supported by 66AK2G
Signed-off-by: Franklin S Cooper Jr <[email protected]>
---
arch/arm/configs/keystone_defconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig
index d47ea43..47be99e 100644
--- a/arch/arm/configs/keystone_defconfig
+++ b/arch/arm/configs/keystone_defconfig
@@ -112,6 +112,9 @@ CONFIG_IP_NF_ARP_MANGLE=y
CONFIG_IP6_NF_IPTABLES=m
CONFIG_IP_SCTP=y
CONFIG_VLAN_8021Q=y
+CONFIG_CAN=m
+CONFIG_CAN_C_CAN=m
+CONFIG_CAN_C_CAN_PLATFORM=m
CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
CONFIG_DEVTMPFS=y
CONFIG_DEVTMPFS_MOUNT=y
--
2.9.4.dirty
Hi Franklin,
On 8/2/2017 1:18 PM, Franklin S Cooper Jr wrote:
> Add D CAN nodes to 66AK2G based SoC dtsi.
>
> Franklin S Cooper Jr (2):
> dt-bindings: net: c_can: Update binding for clock and power-domains
> property
> ARM: configs: keystone: Enable D_CAN driver
>
> Lokesh Vutla (1):
> ARM: dts: k2g: Add DCAN nodes
>
Any DCAN driver dependency with these patchset ? If not, I can
queue this up so do let me know.
Regards,
Santosh
Hi Santosh,
On 08/04/2017 12:07 PM, Santosh Shilimkar wrote:
> Hi Franklin,
>
> On 8/2/2017 1:18 PM, Franklin S Cooper Jr wrote:
>> Add D CAN nodes to 66AK2G based SoC dtsi.
>>
>> Franklin S Cooper Jr (2):
>> dt-bindings: net: c_can: Update binding for clock and power-domains
>> property
>> ARM: configs: keystone: Enable D_CAN driver
>>
>> Lokesh Vutla (1):
>> ARM: dts: k2g: Add DCAN nodes
>>
> Any DCAN driver dependency with these patchset ? If not, I can
> queue this up so do let me know.
There aren't any dependencies.
>
> Regards,
> Santosh
On Wed, Aug 02, 2017 at 03:18:20PM -0500, Franklin S Cooper Jr wrote:
> CAN driver uses the clk_get_rate call to determine the frequency of the
> functional clock. OMAP based SoCs do not require the clock property since
> hwmod already handles creating a "fck" clock thats accessible to drivers.
that's
> However, this isn't the case for 66AK2G which makes the clocks property
> require for that SoC.
required
>
> 66AK2G requires a new property. Therefore, update the binding to also make
> this property requirement clear. Also clarify that for OMAP based SoCs
> ti,hwmod is a required property.
>
> Signed-off-by: Franklin S Cooper Jr <[email protected]>
> ---
> Documentation/devicetree/bindings/net/can/c_can.txt | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
Otherwise,
Acked-by: Rob Herring <[email protected]>
On 8/7/17 2:31 PM, Franklin S Cooper Jr wrote:
>
> Hi Santosh,
> On 08/04/2017 12:07 PM, Santosh Shilimkar wrote:
>> Hi Franklin,
>>
>> On 8/2/2017 1:18 PM, Franklin S Cooper Jr wrote:
>>> Add D CAN nodes to 66AK2G based SoC dtsi.
>>>
>>> Franklin S Cooper Jr (2):
>>> dt-bindings: net: c_can: Update binding for clock and power-domains
>>> property
>>> ARM: configs: keystone: Enable D_CAN driver
>>>
>>> Lokesh Vutla (1):
>>> ARM: dts: k2g: Add DCAN nodes
>>>
>> Any DCAN driver dependency with these patchset ? If not, I can
>> queue this up so do let me know.
>
> There aren't any dependencies.
Applied. Thanks !!
Regards,
Santosh