2019-06-26 16:14:43

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH] drm: fix a reference for a renamed file: fb/modedb.rst

Due to two patches being applied about the same time, the
reference for modedb.rst file got wrong:

Documentation/fb/modedb.txt is now Documentation/fb/modedb.rst.

Fixes: 1bf4e09227c3 ("drm/modes: Allow to specify rotation and reflection on the commandline")
Fixes: ab42b818954c ("docs: fb: convert docs to ReST and rename to *.rst")
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
drivers/gpu/drm/drm_modes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 57e6408288c8..4645af681ef8 100644
--- a/drivers/gpu/drm/drm_modes.c
+++ b/drivers/gpu/drm/drm_modes.c
@@ -1680,7 +1680,7 @@ static int drm_mode_parse_cmdline_options(char *str, size_t len,
*
* Additionals options can be provided following the mode, using a comma to
* separate each option. Valid options can be found in
- * Documentation/fb/modedb.txt.
+ * Documentation/fb/modedb.rst.
*
* The intermediate drm_cmdline_mode structure is required to store additional
* options from the command line modline like the force-enable/disable flag.
--
2.21.0


2019-06-26 21:28:24

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH] drm: fix a reference for a renamed file: fb/modedb.rst

On Wed, Jun 26, 2019 at 01:14:13PM -0300, Mauro Carvalho Chehab wrote:
> Due to two patches being applied about the same time, the
> reference for modedb.rst file got wrong:
>
> Documentation/fb/modedb.txt is now Documentation/fb/modedb.rst.
>
> Fixes: 1bf4e09227c3 ("drm/modes: Allow to specify rotation and reflection on the commandline")
> Fixes: ab42b818954c ("docs: fb: convert docs to ReST and rename to *.rst")
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

What's the merge plan here? doc-next? If so:

Acked-by: Daniel Vetter <[email protected]>
> ---
> drivers/gpu/drm/drm_modes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> index 57e6408288c8..4645af681ef8 100644
> --- a/drivers/gpu/drm/drm_modes.c
> +++ b/drivers/gpu/drm/drm_modes.c
> @@ -1680,7 +1680,7 @@ static int drm_mode_parse_cmdline_options(char *str, size_t len,
> *
> * Additionals options can be provided following the mode, using a comma to
> * separate each option. Valid options can be found in
> - * Documentation/fb/modedb.txt.
> + * Documentation/fb/modedb.rst.
> *
> * The intermediate drm_cmdline_mode structure is required to store additional
> * options from the command line modline like the force-enable/disable flag.
> --
> 2.21.0
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2019-06-27 17:32:46

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] drm: fix a reference for a renamed file: fb/modedb.rst

On Wed, 26 Jun 2019 23:27:35 +0200
Daniel Vetter <[email protected]> wrote:

> On Wed, Jun 26, 2019 at 01:14:13PM -0300, Mauro Carvalho Chehab wrote:
> > Due to two patches being applied about the same time, the
> > reference for modedb.rst file got wrong:
> >
> > Documentation/fb/modedb.txt is now Documentation/fb/modedb.rst.
> >
> > Fixes: 1bf4e09227c3 ("drm/modes: Allow to specify rotation and reflection on the commandline")
> > Fixes: ab42b818954c ("docs: fb: convert docs to ReST and rename to *.rst")
> > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>
> What's the merge plan here? doc-next? If so:
>
> Acked-by: Daniel Vetter <[email protected]>

It doesn't really apply to docs-next, so that's probably not the best
path unless I hold it until after the merge window. Seems like it needs
to go through the DRM tree to me.

Thanks,

jon

2019-06-27 19:45:55

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH] drm: fix a reference for a renamed file: fb/modedb.rst

On Thu, Jun 27, 2019 at 7:31 PM Jonathan Corbet <[email protected]> wrote:
>
> On Wed, 26 Jun 2019 23:27:35 +0200
> Daniel Vetter <[email protected]> wrote:
>
> > On Wed, Jun 26, 2019 at 01:14:13PM -0300, Mauro Carvalho Chehab wrote:
> > > Due to two patches being applied about the same time, the
> > > reference for modedb.rst file got wrong:
> > >
> > > Documentation/fb/modedb.txt is now Documentation/fb/modedb.rst.
> > >
> > > Fixes: 1bf4e09227c3 ("drm/modes: Allow to specify rotation and reflection on the commandline")
> > > Fixes: ab42b818954c ("docs: fb: convert docs to ReST and rename to *.rst")
> > > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> >
> > What's the merge plan here? doc-next? If so:
> >
> > Acked-by: Daniel Vetter <[email protected]>
>
> It doesn't really apply to docs-next, so that's probably not the best
> path unless I hold it until after the merge window. Seems like it needs
> to go through the DRM tree to me.

fbdev isn't in drm (yet), so I don't think it applies here eithe. I
guess we need to wait until after -rc1 with this one. Topic
branch/merge seems a bit overkill here.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch