2019-12-30 17:23:48

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH RFC net-next 06/19] net: dsa: tag_gswip: fix typo in tag name

On Mon, Dec 30, 2019 at 05:30:14PM +0300, Alexander Lobakin wrote:
> "gwsip" -> "gswip".
>
> Signed-off-by: Alexander Lobakin <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew


2020-01-14 22:01:02

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH RFC net-next 06/19] net: dsa: tag_gswip: fix typo in tag name

On 12/30/19 9:22 AM, Andrew Lunn wrote:
> On Mon, Dec 30, 2019 at 05:30:14PM +0300, Alexander Lobakin wrote:
>> "gwsip" -> "gswip".
>>
>> Signed-off-by: Alexander Lobakin <[email protected]>
>
> Reviewed-by: Andrew Lunn <[email protected]>

Likewise, this is a bug fix that should be extracted out of this GRO
series and a Fixes: tag be put since this has an user-visible impact
through /sys/class/net/*/dsa/tagging.

Thanks
--
Florian

2020-01-15 07:26:22

by Alexander Lobakin

[permalink] [raw]
Subject: Re: [PATCH RFC net-next 06/19] net: dsa: tag_gswip: fix typo in tag name

Florian Fainelli wrote 15.01.2020 00:57:
> On 12/30/19 9:22 AM, Andrew Lunn wrote:
>> On Mon, Dec 30, 2019 at 05:30:14PM +0300, Alexander Lobakin wrote:
>>> "gwsip" -> "gswip".
>>>
>>> Signed-off-by: Alexander Lobakin <[email protected]>
>>
>> Reviewed-by: Andrew Lunn <[email protected]>
>
> Likewise, this is a bug fix that should be extracted out of this GRO
> series and a Fixes: tag be put since this has an user-visible impact
> through /sys/class/net/*/dsa/tagging.

Sure, I'll pull some really important fixes (like this one and doubled
Tx stats in tag_qca) out of this series and submit them as separate
patches, maybe even in net-fixes tree?

> Thanks

Regards,
ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ