2019-08-09 11:47:04

by Cao jin

Subject: [PATCH] x86/fixmap: update stale comments

Signed-off-by: Cao jin <[email protected]>
---
arch/x86/include/asm/fixmap.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h
index 9da8cccdf3fb..0c47aa82e2e2 100644
--- a/arch/x86/include/asm/fixmap.h
+++ b/arch/x86/include/asm/fixmap.h
@@ -42,8 +42,7 @@
* Because of this, FIXADDR_TOP x86 integration was left as later work.
*/
#ifdef CONFIG_X86_32
-/* used by vmalloc.c, vsyscall.lds.S.
- *
+/*
* Leave one empty page between vmalloc'ed areas and
* the start of the fixmap.
*/
@@ -120,7 +119,7 @@ enum fixed_addresses {
* before ioremap() is functional.
*
* If necessary we round it up to the next 512 pages boundary so
- * that we can have a single pgd entry and a single pte table:
+ * that we can have a single pmd entry and a single pte table:
*/
#define NR_FIX_BTMAPS 64
#define FIX_BTMAPS_SLOTS 8
--
2.17.0

2019-08-15 02:46:59

by Cao jin

Subject: Re: [PATCH] x86/fixmap: update stale comments

Hi,
Wish to know whether the patch make sense.

On 8/9/19 7:46 PM, Cao jin wrote:
> Signed-off-by: Cao jin <[email protected]>
> ---
> arch/x86/include/asm/fixmap.h | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h
> index 9da8cccdf3fb..0c47aa82e2e2 100644
> --- a/arch/x86/include/asm/fixmap.h
> +++ b/arch/x86/include/asm/fixmap.h
> @@ -42,8 +42,7 @@
> * Because of this, FIXADDR_TOP x86 integration was left as later work.
> */
> #ifdef CONFIG_X86_32
> -/* used by vmalloc.c, vsyscall.lds.S.
> - *
> +/*

Not seeing variable __FIXADDR_TOP & macro FIXADDR_TOP under
CONFIG_X86_32 referred in vmalloc.c, and there is no vsyscall.lds.S now.

> * Leave one empty page between vmalloc'ed areas and
> * the start of the fixmap.
> */
> @@ -120,7 +119,7 @@ enum fixed_addresses {
> * before ioremap() is functional.
> *
> * If necessary we round it up to the next 512 pages boundary so
> - * that we can have a single pgd entry and a single pte table:
> + * that we can have a single pmd entry and a single pte table:

The comments seems missed to be updated in an ancient commit 551889a6e2a24
> */
> #define NR_FIX_BTMAPS 64
> #define FIX_BTMAPS_SLOTS 8
>

--
Sincerely,
Cao jin

2019-08-23 16:14:59

by tip-bot2 for Jacob Pan

Subject: [tip: x86/mm] x86/fixmap: Cleanup outdated comments

The following commit has been merged into the x86/mm branch of tip:

Commit-ID: c84b82dd3e593db217f23c60f7edae02c76a3c4c
Gitweb: https://git.kernel.org/tip/c84b82dd3e593db217f23c60f7edae02c76a3c4c
Author: Cao jin <[email protected]>
AuthorDate: Fri, 09 Aug 2019 19:46:12 +08:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Mon, 19 Aug 2019 21:50:19 +02:00

x86/fixmap: Cleanup outdated comments

Remove stale comments and fix the not longer valid pagetable entry
reference.

Signed-off-by: Cao jin <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]

---
arch/x86/include/asm/fixmap.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h
index 9da8ccc..0c47aa8 100644
--- a/arch/x86/include/asm/fixmap.h
+++ b/arch/x86/include/asm/fixmap.h
@@ -42,8 +42,7 @@
* Because of this, FIXADDR_TOP x86 integration was left as later work.
*/
#ifdef CONFIG_X86_32
-/* used by vmalloc.c, vsyscall.lds.S.
- *
+/*
* Leave one empty page between vmalloc'ed areas and
* the start of the fixmap.
*/
@@ -120,7 +119,7 @@ enum fixed_addresses {
* before ioremap() is functional.
*
* If necessary we round it up to the next 512 pages boundary so
- * that we can have a single pgd entry and a single pte table:
+ * that we can have a single pmd entry and a single pte table:
*/
#define NR_FIX_BTMAPS 64
#define FIX_BTMAPS_SLOTS 8