2019-05-13 16:41:11

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [RFC KVM 01/27] kernel: Export memory-management symbols required for KVM address space isolation

On Mon, May 13, 2019 at 04:38:09PM +0200, Alexandre Chartre wrote:
> From: Liran Alon <[email protected]>
>
> Export symbols needed to create, manage, populate and switch
> a mm from a kernel module (kvm in this case).
>
> This is a hacky way for now to start.
> This should be changed to some suitable memory-management API.

This should not be exported at all, ever, end of story.

Modules do not get to play with address spaces like that.


2019-05-13 16:42:49

by Liran Alon

[permalink] [raw]
Subject: Re: [RFC KVM 01/27] kernel: Export memory-management symbols required for KVM address space isolation



> On 13 May 2019, at 18:15, Peter Zijlstra <[email protected]> wrote:
>
> On Mon, May 13, 2019 at 04:38:09PM +0200, Alexandre Chartre wrote:
>> From: Liran Alon <[email protected]>
>>
>> Export symbols needed to create, manage, populate and switch
>> a mm from a kernel module (kvm in this case).
>>
>> This is a hacky way for now to start.
>> This should be changed to some suitable memory-management API.
>
> This should not be exported at all, ever, end of story.
>
> Modules do not get to play with address spaces like that.

I agree… No doubt about that. This should never be merged like this.
It’s just to have an initial PoC of the concept so we can:
1) Messure performance impact of concept.
2) Get feedback on appropriate design and APIs from community.

-Liran