2016-03-20 18:54:16

by Colin King

Subject: [PATCH] mfd: da9063: remove unused array mask_events_buf

From: Colin Ian King <[email protected]>

mask_events_buf is not used, so remove this redundant array.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/mfd/da9063-irq.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
index 2630263..0aa760e 100644
--- a/drivers/mfd/da9063-irq.c
+++ b/drivers/mfd/da9063-irq.c
@@ -27,8 +27,6 @@
#define DA9063_REG_EVENT_D_OFFSET 3
#define EVENTS_BUF_LEN 4

-static const u8 mask_events_buf[] = { [0 ... (EVENTS_BUF_LEN - 1)] = ~0 };
-
struct da9063_irq_data {
u16 reg;
u8 mask;
--
2.7.3

2016-03-21 10:50:53

by Steve Twiss

Subject: RE: [PATCH] mfd: da9063: remove unused array mask_events_buf

On 20 March 2016 18:54 Colin King wrote:

> Subject: [PATCH] mfd: da9063: remove unused array mask_events_buf
> From: Colin Ian King <[email protected]>
>
> mask_events_buf is not used, so remove this redundant array.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/mfd/da9063-irq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> index 2630263..0aa760e 100644
> --- a/drivers/mfd/da9063-irq.c
> +++ b/drivers/mfd/da9063-irq.c
> @@ -27,8 +27,6 @@
> #define DA9063_REG_EVENT_D_OFFSET 3
> #define EVENTS_BUF_LEN 4

I guess EVENTS_BUF_LEN can go as well.
If this is not added, I will send a patch later.

Regards,
Steve

Acked-by: Steve Twiss <[email protected]>

>
> -static const u8 mask_events_buf[] = { [0 ... (EVENTS_BUF_LEN - 1)] = ~0 };
> -
> struct da9063_irq_data {
> u16 reg;
> u8 mask;
> --
> 2.7.3

2016-03-21 11:54:09

by Lee Jones

Subject: Re: [PATCH] mfd: da9063: remove unused array mask_events_buf

On Sun, 20 Mar 2016, Colin King wrote:

> From: Colin Ian King <[email protected]>
>
> mask_events_buf is not used, so remove this redundant array.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/mfd/da9063-irq.c | 2 --
> 1 file changed, 2 deletions(-)

I've amended the $SUBJECT line to conform to the subsystem style.

Patch applied, thanks.

> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> index 2630263..0aa760e 100644
> --- a/drivers/mfd/da9063-irq.c
> +++ b/drivers/mfd/da9063-irq.c
> @@ -27,8 +27,6 @@
> #define DA9063_REG_EVENT_D_OFFSET 3
> #define EVENTS_BUF_LEN 4
>
> -static const u8 mask_events_buf[] = { [0 ... (EVENTS_BUF_LEN - 1)] = ~0 };
> -
> struct da9063_irq_data {
> u16 reg;
> u8 mask;

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog