2018-12-05 06:50:54

by Jian-Hong Pan

[permalink] [raw]
Subject: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

From: Chris Chiu <[email protected]>

Acer Aspire U27-880(AIO) with ALC286 codec can not detect headset mic
and internal mic not working either. It needs the similar quirk like
Sony laptops to fix headphone jack sensing and enables use of the
internal microphone.

Unfortunately jack sensing for the headset mic is still not working.

Signed-off-by: Jian-Hong Pan <[email protected]>
Signed-off-by: Daniel Drake <[email protected]>
Signed-off-by: Chris Chiu <[email protected]>
---
sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index c0b289ba397f..f21d52eb2ed3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5516,6 +5516,7 @@ enum {
ALC221_FIXUP_HP_HEADSET_MIC,
ALC285_FIXUP_LENOVO_HEADPHONE_NOISE,
ALC295_FIXUP_HP_AUTO_MUTE,
+ ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
};

static const struct hda_fixup alc269_fixups[] = {
@@ -6393,6 +6394,15 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc_fixup_auto_mute_via_amp,
},
+ [ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x18, 0x01a1913c }, /* use as headset mic, without its own jack detect */
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC269_FIXUP_HEADSET_MIC
+ },
};

static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -7071,6 +7081,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
{0x14, 0x90170110},
{0x19, 0x04a11040},
{0x21, 0x04211020}),
+ SND_HDA_PIN_QUIRK(0x10ec0286, 0x1025, "Acer", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
+ {0x12, 0x90a60130},
+ {0x17, 0x90170110},
+ {0x21, 0x02211020}),
SND_HDA_PIN_QUIRK(0x10ec0288, 0x1028, "Dell", ALC288_FIXUP_DELL1_MIC_NO_PRESENCE,
{0x12, 0x90a60120},
{0x14, 0x90170110},
--
2.11.0



2018-12-05 06:51:02

by Jian-Hong Pan

[permalink] [raw]
Subject: [PATCH 2/4] ALSA: hda/realtek - Add support for Acer Aspire C24-860 headset mic

From: Chris Chiu <[email protected]>

The Acer AIO Aspire C24-860 with ALC286 can't detect the headset
microphone. Just like another Acer AIO U27-880, it needs a different
pin value for 0x18 and the headset fixup to make headset mic work.

Signed-off-by: Jian-Hong Pan <[email protected]>
Signed-off-by: Daniel Drake <[email protected]>
Signed-off-by: Chris Chiu <[email protected]>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f21d52eb2ed3..5a7a297546db 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6417,6 +6417,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1025, 0x0762, "Acer Aspire E1-472", ALC271_FIXUP_HP_GATE_MIC_JACK_E1_572),
SND_PCI_QUIRK(0x1025, 0x0775, "Acer Aspire E1-572", ALC271_FIXUP_HP_GATE_MIC_JACK_E1_572),
SND_PCI_QUIRK(0x1025, 0x079b, "Acer Aspire V5-573G", ALC282_FIXUP_ASPIRE_V5_PINS),
+ SND_PCI_QUIRK(0x1025, 0x102b, "Acer Aspire C24-860", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1025, 0x106d, "Acer Cloudbook 14", ALC283_FIXUP_CHROME_BOOK),
SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z),
SND_PCI_QUIRK(0x1028, 0x054b, "Dell XPS one 2710", ALC275_FIXUP_DELL_XPS),
--
2.11.0


2018-12-05 06:51:06

by Jian-Hong Pan

[permalink] [raw]
Subject: [PATCH 4/4] ALSA: hda/realtek: Fix mic issue on Acer AIO Veriton Z4860G/Z6860G

From: Chris Chiu <[email protected]>

Acer AIO Veriton Z4860G/Z6860G with the same ALC286 codec has issues
with the input from external microphone. The issue can be fixed by
the fixup ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE for Veriton Z4660G.

Signed-off-by: Jian-Hong Pan <[email protected]>
Signed-off-by: Daniel Drake <[email protected]>
Signed-off-by: Chris Chiu <[email protected]>
---
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 98f0abaa3540..bb40624fb6d5 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6419,6 +6419,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1025, 0x079b, "Acer Aspire V5-573G", ALC282_FIXUP_ASPIRE_V5_PINS),
SND_PCI_QUIRK(0x1025, 0x102b, "Acer Aspire C24-860", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1025, 0x106d, "Acer Cloudbook 14", ALC283_FIXUP_CHROME_BOOK),
+ SND_PCI_QUIRK(0x1025, 0x128f, "Acer Veriton Z6860G", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z),
SND_PCI_QUIRK(0x1028, 0x054b, "Dell XPS one 2710", ALC275_FIXUP_DELL_XPS),
--
2.11.0


2018-12-05 06:51:59

by Jian-Hong Pan

[permalink] [raw]
Subject: [PATCH 3/4] ALSA: hda/realtek: Fix mic issue on Acer AIO Veriton Z4660G

From: Chris Chiu <[email protected]>

Acer AIO Veriton Z4660G with ALC286 codec has issue with the input
from external microphones connecting via 'Front Mic' jack. The fixup
ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE enables the jack sensing of
the headset and fix the audio input issue of external microphone.

Signed-off-by: Jian-Hong Pan <[email protected]>
Signed-off-by: Daniel Drake <[email protected]>
Signed-off-by: Chris Chiu <[email protected]>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 5a7a297546db..98f0abaa3540 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6419,6 +6419,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1025, 0x079b, "Acer Aspire V5-573G", ALC282_FIXUP_ASPIRE_V5_PINS),
SND_PCI_QUIRK(0x1025, 0x102b, "Acer Aspire C24-860", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1025, 0x106d, "Acer Cloudbook 14", ALC283_FIXUP_CHROME_BOOK),
+ SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z),
SND_PCI_QUIRK(0x1028, 0x054b, "Dell XPS one 2710", ALC275_FIXUP_DELL_XPS),
SND_PCI_QUIRK(0x1028, 0x05bd, "Dell Latitude E6440", ALC292_FIXUP_DELL_E7X),
--
2.11.0


2018-12-05 08:55:56

by Kailang

[permalink] [raw]
Subject: RE: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

Hi Jian Hong,

Please also try to change model to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC.

+ .chain_id = ALC269_FIXUP_HEADSET_MIC ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC

BR,
Kailang
-----Original Message-----
From: Jian-Hong Pan <[email protected]>
Sent: Wednesday, December 5, 2018 2:49 PM
To: Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>
Cc: Kailang <[email protected]>; Hui Wang <[email protected]>; [email protected]; [email protected]; [email protected]; Chris Chiu <[email protected]>; Jian-Hong Pan <[email protected]>; Daniel Drake <[email protected]>
Subject: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

From: Chris Chiu <[email protected]>

Acer Aspire U27-880(AIO) with ALC286 codec can not detect headset mic and internal mic not working either. It needs the similar quirk like Sony laptops to fix headphone jack sensing and enables use of the internal microphone.

Unfortunately jack sensing for the headset mic is still not working.

Signed-off-by: Jian-Hong Pan <[email protected]>
Signed-off-by: Daniel Drake <[email protected]>
Signed-off-by: Chris Chiu <[email protected]>
---
sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index c0b289ba397f..f21d52eb2ed3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5516,6 +5516,7 @@ enum {
ALC221_FIXUP_HP_HEADSET_MIC,
ALC285_FIXUP_LENOVO_HEADPHONE_NOISE,
ALC295_FIXUP_HP_AUTO_MUTE,
+ ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
};

static const struct hda_fixup alc269_fixups[] = { @@ -6393,6 +6394,15 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc_fixup_auto_mute_via_amp,
},
+ [ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x18, 0x01a1913c }, /* use as headset mic, without its own jack detect */
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC269_FIXUP_HEADSET_MIC
+ },
};

static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -7071,6 +7081,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
{0x14, 0x90170110},
{0x19, 0x04a11040},
{0x21, 0x04211020}),
+ SND_HDA_PIN_QUIRK(0x10ec0286, 0x1025, "Acer", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
+ {0x12, 0x90a60130},
+ {0x17, 0x90170110},
+ {0x21, 0x02211020}),
SND_HDA_PIN_QUIRK(0x10ec0288, 0x1028, "Dell", ALC288_FIXUP_DELL1_MIC_NO_PRESENCE,
{0x12, 0x90a60120},
{0x14, 0x90170110},
--
2.11.0


2018-12-05 09:08:20

by Kailang

[permalink] [raw]
Subject: RE: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

Sorry!!
Don't change this.

-----Original Message-----
From: Kailang
Sent: Wednesday, December 5, 2018 4:52 PM
To: 'Jian-Hong Pan' <[email protected]>; Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>
Cc: Hui Wang <[email protected]>; [email protected]; [email protected]; [email protected]; Chris Chiu <[email protected]>; Daniel Drake <[email protected]>
Subject: RE: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

Hi Jian Hong,

Please also try to change model to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC.

+ .chain_id = ALC269_FIXUP_HEADSET_MIC ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC

BR,
Kailang
-----Original Message-----
From: Jian-Hong Pan <[email protected]>
Sent: Wednesday, December 5, 2018 2:49 PM
To: Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>
Cc: Kailang <[email protected]>; Hui Wang <[email protected]>; [email protected]; [email protected]; [email protected]; Chris Chiu <[email protected]>; Jian-Hong Pan <[email protected]>; Daniel Drake <[email protected]>
Subject: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

From: Chris Chiu <[email protected]>

Acer Aspire U27-880(AIO) with ALC286 codec can not detect headset mic and internal mic not working either. It needs the similar quirk like Sony laptops to fix headphone jack sensing and enables use of the internal microphone.

Unfortunately jack sensing for the headset mic is still not working.

Signed-off-by: Jian-Hong Pan <[email protected]>
Signed-off-by: Daniel Drake <[email protected]>
Signed-off-by: Chris Chiu <[email protected]>
---
sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index c0b289ba397f..f21d52eb2ed3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5516,6 +5516,7 @@ enum {
ALC221_FIXUP_HP_HEADSET_MIC,
ALC285_FIXUP_LENOVO_HEADPHONE_NOISE,
ALC295_FIXUP_HP_AUTO_MUTE,
+ ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
};

static const struct hda_fixup alc269_fixups[] = { @@ -6393,6 +6394,15 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc_fixup_auto_mute_via_amp,
},
+ [ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x18, 0x01a1913c }, /* use as headset mic, without its own jack detect */
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC269_FIXUP_HEADSET_MIC
+ },
};

static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -7071,6 +7081,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
{0x14, 0x90170110},
{0x19, 0x04a11040},
{0x21, 0x04211020}),
+ SND_HDA_PIN_QUIRK(0x10ec0286, 0x1025, "Acer", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
+ {0x12, 0x90a60130},
+ {0x17, 0x90170110},
+ {0x21, 0x02211020}),
SND_HDA_PIN_QUIRK(0x10ec0288, 0x1028, "Dell", ALC288_FIXUP_DELL1_MIC_NO_PRESENCE,
{0x12, 0x90a60120},
{0x14, 0x90170110},
--
2.11.0


2018-12-05 09:33:50

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

On Wed, 05 Dec 2018 10:06:14 +0100,
Kailang wrote:
>
> Sorry!!
> Don't change this.

Hm, should I apply these series or not?


thanks,

Takashi

>
> -----Original Message-----
> From: Kailang
> Sent: Wednesday, December 5, 2018 4:52 PM
> To: 'Jian-Hong Pan' <[email protected]>; Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>
> Cc: Hui Wang <[email protected]>; [email protected]; [email protected]; [email protected]; Chris Chiu <[email protected]>; Daniel Drake <[email protected]>
> Subject: RE: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880
>
> Hi Jian Hong,
>
> Please also try to change model to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC.
>
> + .chain_id = ALC269_FIXUP_HEADSET_MIC ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
>
> BR,
> Kailang
> -----Original Message-----
> From: Jian-Hong Pan <[email protected]>
> Sent: Wednesday, December 5, 2018 2:49 PM
> To: Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>
> Cc: Kailang <[email protected]>; Hui Wang <[email protected]>; [email protected]; [email protected]; [email protected]; Chris Chiu <[email protected]>; Jian-Hong Pan <[email protected]>; Daniel Drake <[email protected]>
> Subject: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880
>
> From: Chris Chiu <[email protected]>
>
> Acer Aspire U27-880(AIO) with ALC286 codec can not detect headset mic and internal mic not working either. It needs the similar quirk like Sony laptops to fix headphone jack sensing and enables use of the internal microphone.
>
> Unfortunately jack sensing for the headset mic is still not working.
>
> Signed-off-by: Jian-Hong Pan <[email protected]>
> Signed-off-by: Daniel Drake <[email protected]>
> Signed-off-by: Chris Chiu <[email protected]>
> ---
> sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index c0b289ba397f..f21d52eb2ed3 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5516,6 +5516,7 @@ enum {
> ALC221_FIXUP_HP_HEADSET_MIC,
> ALC285_FIXUP_LENOVO_HEADPHONE_NOISE,
> ALC295_FIXUP_HP_AUTO_MUTE,
> + ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
> };
>
> static const struct hda_fixup alc269_fixups[] = { @@ -6393,6 +6394,15 @@ static const struct hda_fixup alc269_fixups[] = {
> .type = HDA_FIXUP_FUNC,
> .v.func = alc_fixup_auto_mute_via_amp,
> },
> + [ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE] = {
> + .type = HDA_FIXUP_PINS,
> + .v.pins = (const struct hda_pintbl[]) {
> + { 0x18, 0x01a1913c }, /* use as headset mic, without its own jack detect */
> + { }
> + },
> + .chained = true,
> + .chain_id = ALC269_FIXUP_HEADSET_MIC
> + },
> };
>
> static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -7071,6 +7081,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
> {0x14, 0x90170110},
> {0x19, 0x04a11040},
> {0x21, 0x04211020}),
> + SND_HDA_PIN_QUIRK(0x10ec0286, 0x1025, "Acer", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
> + {0x12, 0x90a60130},
> + {0x17, 0x90170110},
> + {0x21, 0x02211020}),
> SND_HDA_PIN_QUIRK(0x10ec0288, 0x1028, "Dell", ALC288_FIXUP_DELL1_MIC_NO_PRESENCE,
> {0x12, 0x90a60120},
> {0x14, 0x90170110},
> --
> 2.11.0
>
>

2018-12-05 12:40:59

by Kailang

[permalink] [raw]
Subject: RE: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

Hi Takashi,

You should apply alc286 platform first.
I think they had test passed already.
ALC294 platform just wait for test via change model.

BR,
Kailang
________________________________________
?q: Takashi Iwai [[email protected]]
?H??????: 2018?~12??5?? ?U?? 05:32
??: Kailang
?ƥ?: Jian-Hong Pan; Jaroslav Kysela; [email protected]; Hui Wang; Chris Chiu; Daniel Drake; [email protected]; [email protected]
?D??: Re: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

On Wed, 05 Dec 2018 10:06:14 +0100,
Kailang wrote:
>
> Sorry!!
> Don't change this.

Hm, should I apply these series or not?


thanks,

Takashi

>
> -----Original Message-----
> From: Kailang
> Sent: Wednesday, December 5, 2018 4:52 PM
> To: 'Jian-Hong Pan' <[email protected]>; Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>
> Cc: Hui Wang <[email protected]>; [email protected]; [email protected]; [email protected]; Chris Chiu <[email protected]>; Daniel Drake <[email protected]>
> Subject: RE: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880
>
> Hi Jian Hong,
>
> Please also try to change model to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC.
>
> + .chain_id = ALC269_FIXUP_HEADSET_MIC ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
>
> BR,
> Kailang
> -----Original Message-----
> From: Jian-Hong Pan <[email protected]>
> Sent: Wednesday, December 5, 2018 2:49 PM
> To: Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>
> Cc: Kailang <[email protected]>; Hui Wang <[email protected]>; [email protected]; [email protected]; [email protected]; Chris Chiu <[email protected]>; Jian-Hong Pan <[email protected]>; Daniel Drake <[email protected]>
> Subject: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880
>
> From: Chris Chiu <[email protected]>
>
> Acer Aspire U27-880(AIO) with ALC286 codec can not detect headset mic and internal mic not working either. It needs the similar quirk like Sony laptops to fix headphone jack sensing and enables use of the internal microphone.
>
> Unfortunately jack sensing for the headset mic is still not working.
>
> Signed-off-by: Jian-Hong Pan <[email protected]>
> Signed-off-by: Daniel Drake <[email protected]>
> Signed-off-by: Chris Chiu <[email protected]>
> ---
> sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index c0b289ba397f..f21d52eb2ed3 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5516,6 +5516,7 @@ enum {
> ALC221_FIXUP_HP_HEADSET_MIC,
> ALC285_FIXUP_LENOVO_HEADPHONE_NOISE,
> ALC295_FIXUP_HP_AUTO_MUTE,
> + ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
> };
>
> static const struct hda_fixup alc269_fixups[] = { @@ -6393,6 +6394,15 @@ static const struct hda_fixup alc269_fixups[] = {
> .type = HDA_FIXUP_FUNC,
> .v.func = alc_fixup_auto_mute_via_amp,
> },
> + [ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE] = {
> + .type = HDA_FIXUP_PINS,
> + .v.pins = (const struct hda_pintbl[]) {
> + { 0x18, 0x01a1913c }, /* use as headset mic, without its own jack detect */
> + { }
> + },
> + .chained = true,
> + .chain_id = ALC269_FIXUP_HEADSET_MIC
> + },
> };
>
> static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -7071,6 +7081,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
> {0x14, 0x90170110},
> {0x19, 0x04a11040},
> {0x21, 0x04211020}),
> + SND_HDA_PIN_QUIRK(0x10ec0286, 0x1025, "Acer", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
> + {0x12, 0x90a60130},
> + {0x17, 0x90170110},
> + {0x21, 0x02211020}),
> SND_HDA_PIN_QUIRK(0x10ec0288, 0x1028, "Dell", ALC288_FIXUP_DELL1_MIC_NO_PRESENCE,
> {0x12, 0x90a60120},
> {0x14, 0x90170110},
> --
> 2.11.0
>
>

------Please consider the environment before printing this e-mail.

2018-12-05 15:38:04

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880

On Wed, 05 Dec 2018 13:37:43 +0100,
Kailang wrote:
>
> Hi Takashi,
>
> You should apply alc286 platform first.
> I think they had test passed already.
> ALC294 platform just wait for test via change model.

OK, now applied this series for ALC286.
For ALC294, I'll wait for the test result.


thanks,

Takashi

>
> BR,
> Kailang
> ________________________________________
> 從: Takashi Iwai [[email protected]]
> 寄件日期: 2018年12月5日 下午 05:32
> 至: Kailang
> 副本: Jian-Hong Pan; Jaroslav Kysela; [email protected]; Hui Wang; Chris Chiu; Daniel Drake; [email protected]; [email protected]
> 主旨: Re: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880
>
> On Wed, 05 Dec 2018 10:06:14 +0100,
> Kailang wrote:
> >
> > Sorry!!
> > Don't change this.
>
> Hm, should I apply these series or not?
>
>
> thanks,
>
> Takashi
>
> >
> > -----Original Message-----
> > From: Kailang
> > Sent: Wednesday, December 5, 2018 4:52 PM
> > To: 'Jian-Hong Pan' <[email protected]>; Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>
> > Cc: Hui Wang <[email protected]>; [email protected]; [email protected]; [email protected]; Chris Chiu <[email protected]>; Daniel Drake <[email protected]>
> > Subject: RE: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880
> >
> > Hi Jian Hong,
> >
> > Please also try to change model to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC.
> >
> > + .chain_id = ALC269_FIXUP_HEADSET_MIC ==> change to ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
> >
> > BR,
> > Kailang
> > -----Original Message-----
> > From: Jian-Hong Pan <[email protected]>
> > Sent: Wednesday, December 5, 2018 2:49 PM
> > To: Jaroslav Kysela <[email protected]>; Takashi Iwai <[email protected]>
> > Cc: Kailang <[email protected]>; Hui Wang <[email protected]>; [email protected]; [email protected]; [email protected]; Chris Chiu <[email protected]>; Jian-Hong Pan <[email protected]>; Daniel Drake <[email protected]>
> > Subject: [PATCH 1/4] ALSA: hda/realtek: ALC286 mic and headset-mode fixups for Acer Aspire U27-880
> >
> > From: Chris Chiu <[email protected]>
> >
> > Acer Aspire U27-880(AIO) with ALC286 codec can not detect headset mic and internal mic not working either. It needs the similar quirk like Sony laptops to fix headphone jack sensing and enables use of the internal microphone.
> >
> > Unfortunately jack sensing for the headset mic is still not working.
> >
> > Signed-off-by: Jian-Hong Pan <[email protected]>
> > Signed-off-by: Daniel Drake <[email protected]>
> > Signed-off-by: Chris Chiu <[email protected]>
> > ---
> > sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index c0b289ba397f..f21d52eb2ed3 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -5516,6 +5516,7 @@ enum {
> > ALC221_FIXUP_HP_HEADSET_MIC,
> > ALC285_FIXUP_LENOVO_HEADPHONE_NOISE,
> > ALC295_FIXUP_HP_AUTO_MUTE,
> > + ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
> > };
> >
> > static const struct hda_fixup alc269_fixups[] = { @@ -6393,6 +6394,15 @@ static const struct hda_fixup alc269_fixups[] = {
> > .type = HDA_FIXUP_FUNC,
> > .v.func = alc_fixup_auto_mute_via_amp,
> > },
> > + [ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE] = {
> > + .type = HDA_FIXUP_PINS,
> > + .v.pins = (const struct hda_pintbl[]) {
> > + { 0x18, 0x01a1913c }, /* use as headset mic, without its own jack detect */
> > + { }
> > + },
> > + .chained = true,
> > + .chain_id = ALC269_FIXUP_HEADSET_MIC
> > + },
> > };
> >
> > static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -7071,6 +7081,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
> > {0x14, 0x90170110},
> > {0x19, 0x04a11040},
> > {0x21, 0x04211020}),
> > + SND_HDA_PIN_QUIRK(0x10ec0286, 0x1025, "Acer", ALC286_FIXUP_ACER_AIO_MIC_NO_PRESENCE,
> > + {0x12, 0x90a60130},
> > + {0x17, 0x90170110},
> > + {0x21, 0x02211020}),
> > SND_HDA_PIN_QUIRK(0x10ec0288, 0x1028, "Dell", ALC288_FIXUP_DELL1_MIC_NO_PRESENCE,
> > {0x12, 0x90a60120},
> > {0x14, 0x90170110},
> > --
> > 2.11.0
> >
> >
>
> ------Please consider the environment before printing this e-mail.