On 11/14/2023 2:58 PM, Jonathan Marek wrote:
> The value returned by msm_dsi_wide_bus_enabled() doesn't match what the
> driver is doing in video mode. Fix that by actually enabling widebus for
> video mode.
>
> Fixes: efcbd6f9cdeb ("drm/msm/dsi: Enable widebus for DSI")
> Signed-off-by: Jonathan Marek <[email protected]>
> ---
> drivers/gpu/drm/msm/dsi/dsi.xml.h | 1 +
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi.xml.h b/drivers/gpu/drm/msm/dsi/dsi.xml.h
> index 2a7d980e12c3..f0b3cdc020a1 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi.xml.h
> +++ b/drivers/gpu/drm/msm/dsi/dsi.xml.h
> @@ -231,6 +231,7 @@ static inline uint32_t DSI_VID_CFG0_TRAFFIC_MODE(enum dsi_traffic_mode val)
> #define DSI_VID_CFG0_HSA_POWER_STOP 0x00010000
> #define DSI_VID_CFG0_HBP_POWER_STOP 0x00100000
> #define DSI_VID_CFG0_HFP_POWER_STOP 0x01000000
> +#define DSI_VID_CFG0_DATABUS_WIDEN 0x02000000
> #define DSI_VID_CFG0_PULSE_MODE_HSA_HE 0x10000000
>
> #define REG_DSI_VID_CFG1 0x0000001c
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index deeecdfd6c4e..f2c1cbd08d4d 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -745,6 +745,8 @@ static void dsi_ctrl_enable(struct msm_dsi_host *msm_host,
> data |= DSI_VID_CFG0_TRAFFIC_MODE(dsi_get_traffic_mode(flags));
> data |= DSI_VID_CFG0_DST_FORMAT(dsi_get_vid_fmt(mipi_fmt));
> data |= DSI_VID_CFG0_VIRT_CHANNEL(msm_host->channel);
> + if (msm_dsi_host_is_wide_bus_enabled(&msm_host->base))
> + data |= DSI_VID_CFG0_DATABUS_WIDEN;
Hi Jonathan,
Now that widebus is enabled for video mode, I think you can also drop
the TODO here [1]. Other than that, this LGTM.
Reviewed-by: Jessica Zhang <[email protected]>
Thanks,
Jessica Zhang
[1]
https://elixir.bootlin.com/linux/v6.7-rc3/source/drivers/gpu/drm/msm/dsi/dsi_host.c#L772
> dsi_write(msm_host, REG_DSI_VID_CFG0, data);
>
> /* Do not swap RGB colors */
> --
> 2.26.1
>