2024-02-08 03:53:02

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the spi tree

Hi all,

After merging the spi tree, today's linux-next build (htmldocs) produced
this warning:

Warning: /sys/devices/pci0000:00/<dev>/fw_version is defined 2 times: Documentation/ABI/testing/sysfs-bus-pci-devices-avs:0 Documentation/ABI/testing/sysfs-bus-pci-devices-catpt:0

Introduced by commit

148b93a5062d ("ASoC: Intel: avs: Expose FW version with sysfs")

You need to make the "<dev>" part unique.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2024-02-08 12:17:22

by Mark Brown

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the spi tree

On Thu, Feb 08, 2024 at 02:52:00PM +1100, Stephen Rothwell wrote:
> Introduced by commit

> 148b93a5062d ("ASoC: Intel: avs: Expose FW version with sysfs")

> You need to make the "<dev>" part unique.

Since it ended up in the wrong tree anyway I'll just drop this.


Attachments:
(No filename) (276.00 B)
signature.asc (499.00 B)
Download all attachments

2024-02-08 13:32:48

by Amadeusz Sławiński

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the spi tree

On 2/8/2024 4:52 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the spi tree, today's linux-next build (htmldocs) produced
> this warning:
>
> Warning: /sys/devices/pci0000:00/<dev>/fw_version is defined 2 times: Documentation/ABI/testing/sysfs-bus-pci-devices-avs:0 Documentation/ABI/testing/sysfs-bus-pci-devices-catpt:0
>
> Introduced by commit
>
> 148b93a5062d ("ASoC: Intel: avs: Expose FW version with sysfs")
>
> You need to make the "<dev>" part unique.
>

Ah! The avs path should've been:
/sys/devices/pci0000:00/<dev>/avs/fw_version
Will "avs/" in path this fix the error?
As far as I know there are at least two possible devices, that's why we
used <dev> in path.

2024-02-08 22:01:07

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the spi tree

Hi Amadeusz,

On Thu, 8 Feb 2024 14:32:15 +0100 Amadeusz Sławiński <[email protected]> wrote:
>
> Ah! The avs path should've been:
> /sys/devices/pci0000:00/<dev>/avs/fw_version
> Will "avs/" in path this fix the error?

Presumably, since the path string will then be unique.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature