2022-11-23 04:45:50

by Asutosh Das

Subject: [PATCH v5 16/16] ufs: core: mcq: Enable Multi Circular Queue

Enable MCQ in the Host Controller.

Signed-off-by: Asutosh Das <[email protected]>
Reviewed-by: Bart Van Assche <[email protected]>
---
drivers/ufs/core/ufshcd.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 8416d42..41005b8 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -8351,6 +8351,12 @@ static void ufshcd_config_mcq(struct ufs_hba *hba)

hba->host->can_queue = hba->nutrs - UFSHCD_NUM_RESERVED;
hba->reserved_slot = hba->nutrs - UFSHCD_NUM_RESERVED;
+
+ /* Select MCQ mode */
+ ufshcd_writel(hba, ufshcd_readl(hba, REG_UFS_MEM_CFG) | 0x1,
+ REG_UFS_MEM_CFG);
+ hba->mcq_enabled = true;
+
dev_info(hba->dev, "MCQ configured, nr_queues=%d, io_queues=%d, read_queue=%d, poll_queues=%d, queue_depth=%d\n",
hba->nr_hw_queues, hba->nr_queues[HCTX_TYPE_DEFAULT],
hba->nr_queues[HCTX_TYPE_READ], hba->nr_queues[HCTX_TYPE_POLL],
--
2.7.4

2022-11-28 18:19:11

by Manivannan Sadhasivam

Subject: Re: [PATCH v5 16/16] ufs: core: mcq: Enable Multi Circular Queue

On Tue, Nov 22, 2022 at 08:10:29PM -0800, Asutosh Das wrote:
> Enable MCQ in the Host Controller.
>
> Signed-off-by: Asutosh Das <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> Reviewed-by: Bart Van Assche <[email protected]>
> ---
> drivers/ufs/core/ufshcd.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 8416d42..41005b8 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -8351,6 +8351,12 @@ static void ufshcd_config_mcq(struct ufs_hba *hba)
>
> hba->host->can_queue = hba->nutrs - UFSHCD_NUM_RESERVED;
> hba->reserved_slot = hba->nutrs - UFSHCD_NUM_RESERVED;
> +
> + /* Select MCQ mode */
> + ufshcd_writel(hba, ufshcd_readl(hba, REG_UFS_MEM_CFG) | 0x1,
> + REG_UFS_MEM_CFG);
> + hba->mcq_enabled = true;
> +
> dev_info(hba->dev, "MCQ configured, nr_queues=%d, io_queues=%d, read_queue=%d, poll_queues=%d, queue_depth=%d\n",
> hba->nr_hw_queues, hba->nr_queues[HCTX_TYPE_DEFAULT],
> hba->nr_queues[HCTX_TYPE_READ], hba->nr_queues[HCTX_TYPE_POLL],
> --
> 2.7.4
>

--
மணிவண்ணன் சதாசிவம்