2019-04-01 05:16:30

by Anson Huang

Subject: [PATCH] mailbox: imx: use devm_platform_ioremap_resource() to simplify code

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/mailbox/imx-mailbox.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
index 85fc5b5..25be8bb 100644
--- a/drivers/mailbox/imx-mailbox.c
+++ b/drivers/mailbox/imx-mailbox.c
@@ -264,7 +264,6 @@ static int imx_mu_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct device_node *np = dev->of_node;
- struct resource *iomem;
struct imx_mu_priv *priv;
unsigned int i;
int ret;
@@ -275,8 +274,7 @@ static int imx_mu_probe(struct platform_device *pdev)

priv->dev = dev;

- iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->base = devm_ioremap_resource(&pdev->dev, iomem);
+ priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);

--
2.7.4

2019-04-01 08:05:00

by Mukesh Ojha

Subject: Re: [PATCH] mailbox: imx: use devm_platform_ioremap_resource() to simplify code

On 4/1/2019 10:45 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> drivers/mailbox/imx-mailbox.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index 85fc5b5..25be8bb 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -264,7 +264,6 @@ static int imx_mu_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> - struct resource *iomem;
> struct imx_mu_priv *priv;
> unsigned int i;
> int ret;
> @@ -275,8 +274,7 @@ static int imx_mu_probe(struct platform_device *pdev)
>
> priv->dev = dev;
>
> - iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, iomem);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>

2019-04-28 06:28:31

by Anson Huang

Subject: RE: [PATCH] mailbox: imx: use devm_platform_ioremap_resource() to simplify code

Ping...

> -----Original Message-----
> From: Anson Huang
> Sent: Monday, April 1, 2019 1:15 PM
> To: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Cc: dl-linux-imx <[email protected]>
> Subject: [PATCH] mailbox: imx: use devm_platform_ioremap_resource() to
> simplify code
>
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to simplify
> the code.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> drivers/mailbox/imx-mailbox.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index 85fc5b5..25be8bb 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -264,7 +264,6 @@ static int imx_mu_probe(struct platform_device
> *pdev) {
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> - struct resource *iomem;
> struct imx_mu_priv *priv;
> unsigned int i;
> int ret;
> @@ -275,8 +274,7 @@ static int imx_mu_probe(struct platform_device
> *pdev)
>
> priv->dev = dev;
>
> - iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, iomem);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base))
> return PTR_ERR(priv->base);
>
> --
> 2.7.4

2019-05-09 01:44:30

by Anson Huang

Subject: RE: [PATCH] mailbox: imx: use devm_platform_ioremap_resource() to simplify code

Ping...

> -----Original Message-----
> From: Anson Huang
> Sent: Sunday, April 28, 2019 2:27 PM
> To: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Cc: dl-linux-imx <[email protected]>
> Subject: RE: [PATCH] mailbox: imx: use devm_platform_ioremap_resource()
> to simplify code
>
> Ping...
>
> > -----Original Message-----
> > From: Anson Huang
> > Sent: Monday, April 1, 2019 1:15 PM
> > To: [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]
> > Cc: dl-linux-imx <[email protected]>
> > Subject: [PATCH] mailbox: imx: use devm_platform_ioremap_resource() to
> > simplify code
> >
> > Use the new helper devm_platform_ioremap_resource() which wraps the
> > platform_get_resource() and devm_ioremap_resource() together, to
> > simplify the code.
> >
> > Signed-off-by: Anson Huang <[email protected]>
> > ---
> > drivers/mailbox/imx-mailbox.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/mailbox/imx-mailbox.c
> > b/drivers/mailbox/imx-mailbox.c index 85fc5b5..25be8bb 100644
> > --- a/drivers/mailbox/imx-mailbox.c
> > +++ b/drivers/mailbox/imx-mailbox.c
> > @@ -264,7 +264,6 @@ static int imx_mu_probe(struct platform_device
> > *pdev) {
> > struct device *dev = &pdev->dev;
> > struct device_node *np = dev->of_node;
> > - struct resource *iomem;
> > struct imx_mu_priv *priv;
> > unsigned int i;
> > int ret;
> > @@ -275,8 +274,7 @@ static int imx_mu_probe(struct platform_device
> > *pdev)
> >
> > priv->dev = dev;
> >
> > - iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - priv->base = devm_ioremap_resource(&pdev->dev, iomem);
> > + priv->base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(priv->base))
> > return PTR_ERR(priv->base);
> >
> > --
> > 2.7.4