2017-06-26 23:19:40

by Wei Yang

Subject: [PATCH] mm/memory_hotplug: remove an unused variable in move_pfn_range_to_zone()

There is an unused variable in move_pfn_range_to_zone().

This patch just removes it.

Signed-off-by: Wei Yang <[email protected]>
---
mm/memory_hotplug.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 514014dde16b..16167c92bbf1 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -899,7 +899,6 @@ void __ref move_pfn_range_to_zone(struct zone *zone,
struct pglist_data *pgdat = zone->zone_pgdat;
int nid = pgdat->node_id;
unsigned long flags;
- unsigned long i;

if (zone_is_empty(zone))
init_currently_empty_zone(zone, start_pfn, nr_pages);
--
2.11.0

2017-06-27 04:56:53

by Anshuman Khandual

Subject: Re: [PATCH] mm/memory_hotplug: remove an unused variable in move_pfn_range_to_zone()

On 06/27/2017 04:49 AM, Wei Yang wrote:
> There is an unused variable in move_pfn_range_to_zone().
>
> This patch just removes it.
>
> Signed-off-by: Wei Yang <[email protected]>
> ---
> mm/memory_hotplug.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 514014dde16b..16167c92bbf1 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -899,7 +899,6 @@ void __ref move_pfn_range_to_zone(struct zone *zone,
> struct pglist_data *pgdat = zone->zone_pgdat;
> int nid = pgdat->node_id;
> unsigned long flags;
> - unsigned long i;
>
> if (zone_is_empty(zone))
> init_currently_empty_zone(zone, start_pfn, nr_pages);

We have this down in the function. IIRC I had checked out tag
mmotm-2017-06-16-13-59 where I am looking out for this function.

for (i = 0; i < nr_pages; i++) {
unsigned long pfn = start_pfn + i;
set_page_links(pfn_to_page(pfn), zone_idx(zone), nid, pfn);
}

2017-06-27 05:25:46

by Michal Hocko

Subject: Re: [PATCH] mm/memory_hotplug: remove an unused variable in move_pfn_range_to_zone()

On Tue 27-06-17 10:26:38, Anshuman Khandual wrote:
> On 06/27/2017 04:49 AM, Wei Yang wrote:
> > There is an unused variable in move_pfn_range_to_zone().
> >
> > This patch just removes it.
> >
> > Signed-off-by: Wei Yang <[email protected]>
> > ---
> > mm/memory_hotplug.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> > index 514014dde16b..16167c92bbf1 100644
> > --- a/mm/memory_hotplug.c
> > +++ b/mm/memory_hotplug.c
> > @@ -899,7 +899,6 @@ void __ref move_pfn_range_to_zone(struct zone *zone,
> > struct pglist_data *pgdat = zone->zone_pgdat;
> > int nid = pgdat->node_id;
> > unsigned long flags;
> > - unsigned long i;
> >
> > if (zone_is_empty(zone))
> > init_currently_empty_zone(zone, start_pfn, nr_pages);
>
> We have this down in the function. IIRC I had checked out tag
> mmotm-2017-06-16-13-59 where I am looking out for this function.

It's a follow up for
mm-memory_hotplug-do-not-associate-hotadded-memory-to-zones-until-online-fix-2.patch
in mmotm-2017-06-23-15-03

>
> for (i = 0; i < nr_pages; i++) {
> unsigned long pfn = start_pfn + i;
> set_page_links(pfn_to_page(pfn), zone_idx(zone), nid, pfn);
> }
>
>

--
Michal Hocko
SUSE Labs