2020-09-24 11:29:30

by Faiz Abbas

[permalink] [raw]
Subject: [PATCH v2 0/2] Add support for MMC/SD on j7200-evm

The following patches add dt support for MMC/SD on TI's j7200-evm.

Currently, eMMC support upto HS200 speed and SD card supports upto high
speed speed mode.

v2:
Fixed node names to use mmc@* format
Fixed reg address format to align with others in the file

Faiz Abbas (2):
arm64: dts: ti: k3-j7200-main: Add support for MMC/SD controller nodes
arm64: dts: ti: k3-j7200-common-proc-board: Add support for eMMC and
SD card

.../dts/ti/k3-j7200-common-proc-board.dts | 28 ++++++++++++++
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 37 +++++++++++++++++++
2 files changed, 65 insertions(+)

--
2.17.1


2020-09-24 11:29:36

by Faiz Abbas

[permalink] [raw]
Subject: [PATCH v2 2/2] arm64: dts: ti: k3-j7200-common-proc-board: Add support for eMMC and SD card

Add support for the eMMC and SD card connected on the common
processor board

sdhci0 is connected to an eMMC while sdhci1 is connected to the
micro SD slot.

Signed-off-by: Faiz Abbas <[email protected]>
---
.../dts/ti/k3-j7200-common-proc-board.dts | 28 +++++++++++++++++++
1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
index 03c8817e8745..794241ba74cb 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
@@ -28,6 +28,19 @@
J721E_IOPAD(0xe0, PIN_INPUT_PULLUP, 3) /* (T3) EXT_REFCLK1.I2C1_SDA */
>;
};
+
+ main_mmc1_pins_default: main-mmc1-pins-default {
+ pinctrl-single,pins = <
+ J721E_IOPAD(0x104, PIN_INPUT, 0) /* (M20) MMC1_CMD */
+ J721E_IOPAD(0x100, PIN_INPUT, 0) /* (P21) MMC1_CLK */
+ J721E_IOPAD(0xfc, PIN_INPUT, 0) /* (P25) MMC1_CLKLB */
+ J721E_IOPAD(0xf8, PIN_INPUT, 0) /* (M19) MMC1_DAT0 */
+ J721E_IOPAD(0xf4, PIN_INPUT, 0) /* (N21) MMC1_DAT1 */
+ J721E_IOPAD(0xf0, PIN_INPUT, 0) /* (N20) MMC1_DAT2 */
+ J721E_IOPAD(0xec, PIN_INPUT, 0) /* (N19) MMC1_DAT3 */
+ J721E_IOPAD(0xe4, PIN_INPUT, 8) /* (V1) TIMER_IO0.MMC1_SDCD */
+ >;
+ };
};

&wkup_uart0 {
@@ -112,3 +125,18 @@
#gpio-cells = <2>;
};
};
+
+&main_sdhci0 {
+ /* eMMC */
+ non-removable;
+ ti,driver-strength-ohm = <50>;
+ disable-wp;
+};
+
+&main_sdhci1 {
+ /* SD card */
+ pinctrl-0 = <&main_mmc1_pins_default>;
+ pinctrl-names = "default";
+ ti,driver-strength-ohm = <50>;
+ disable-wp;
+};
--
2.17.1

2020-09-24 11:53:57

by Sekhar Nori

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Add support for MMC/SD on j7200-evm

On 24/09/20 4:56 PM, Faiz Abbas wrote:
> The following patches add dt support for MMC/SD on TI's j7200-evm.
>
> Currently, eMMC support upto HS200 speed and SD card supports upto high
> speed speed mode.

To be sure, the TRM calls for SD card speed up to DDR50. And I believe
there is work going on to go higher too. That needs voltage switching
though and can come in as follow-on patches. This is good first step.

Reviewed-by: Sekhar Nori <[email protected]>

Thanks,
Sekhar

2020-09-24 12:02:28

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Add support for MMC/SD on j7200-evm



On 9/24/20 4:56 PM, Faiz Abbas wrote:
> The following patches add dt support for MMC/SD on TI's j7200-evm.
>
> Currently, eMMC support upto HS200 speed and SD card supports upto high
> speed speed mode.
>
> v2:
> Fixed node names to use mmc@* format
> Fixed reg address format to align with others in the file
>
> Faiz Abbas (2):
> arm64: dts: ti: k3-j7200-main: Add support for MMC/SD controller nodes
> arm64: dts: ti: k3-j7200-common-proc-board: Add support for eMMC and
> SD card
>
> .../dts/ti/k3-j7200-common-proc-board.dts | 28 ++++++++++++++
> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 37 +++++++++++++++++++
> 2 files changed, 65 insertions(+)
>
For the series:

Tested-by: Vignesh Raghavendra <[email protected]>


[ 1.678263] mmc0: Command Queue Engine enabled
[ 1.682727] mmc0: new HS200 MMC card at address 0001
[ 1.688193] mmcblk0: mmc0:0001 S0J56X 14.8 GiB
[ 1.692971] mmcblk0boot0: mmc0:0001 S0J56X partition 1 31.5 MiB
[ 1.699138] mmcblk0boot1: mmc0:0001 S0J56X partition 2 31.5 MiB
[ 1.705268] mmcblk0rpmb: mmc0:0001 S0J56X partition 3 4.00 MiB, ch
ardev (240:0)
[ 1.789527] mmc1: new high speed SDHC card at address aaaa
[ 1.795621] mmcblk1: mmc1:aaaa SC16G 14.8 GiB
[ 1.810074] mmcblk1: p1 p2


SD hot plug works fine too..
Full log: https://pastebin.ubuntu.com/p/5hcCQDjhtW/

2020-09-24 12:17:41

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Add support for MMC/SD on j7200-evm

On Thu, 24 Sep 2020 16:56:42 +0530, Faiz Abbas wrote:
> The following patches add dt support for MMC/SD on TI's j7200-evm.
>
> Currently, eMMC support upto HS200 speed and SD card supports upto high
> speed speed mode.
>
> v2:
> Fixed node names to use mmc@* format
> Fixed reg address format to align with others in the file
>
> [...]

Hi Faiz Abbas,

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/2] arm64: dts: ti: k3-j7200-main: Add support for MMC/SD controller nodes
commit: 7cd03dc78b290400875b6b54e257ba5ea4e810c3
[2/2] arm64: dts: ti: k3-j7200-common-proc-board: Add support for eMMC and SD card
commit: a2178b83ae8f61b2a9fae2aa9a4d4ed2511690a4


All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D