2021-08-01 15:39:45

by Colin King

Subject: [PATCH] net/mlx4: make the array states static const, makes object smaller

From: Colin Ian King <[email protected]>

Don't populate the array states on the stack but instead it
static const. Makes the object code smaller by 79 bytes.

Before:
text data bss dec hex filename
21309 8304 192 29805 746d drivers/net/ethernet/mellanox/mlx4/qp.o

After:
text data bss dec hex filename
21166 8368 192 29726 741e drivers/net/ethernet/mellanox/mlx4/qp.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/mellanox/mlx4/qp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/qp.c b/drivers/net/ethernet/mellanox/mlx4/qp.c
index 427e7a31862c..2584bc038f94 100644
--- a/drivers/net/ethernet/mellanox/mlx4/qp.c
+++ b/drivers/net/ethernet/mellanox/mlx4/qp.c
@@ -917,7 +917,7 @@ int mlx4_qp_to_ready(struct mlx4_dev *dev, struct mlx4_mtt *mtt,
{
int err;
int i;
- enum mlx4_qp_state states[] = {
+ static const enum mlx4_qp_state states[] = {
MLX4_QP_STATE_RST,
MLX4_QP_STATE_INIT,
MLX4_QP_STATE_RTR,
--
2.31.1

2021-08-02 08:46:28

by Leon Romanovsky

Subject: Re: [PATCH] net/mlx4: make the array states static const, makes object smaller

On Sun, Aug 01, 2021 at 04:37:42PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Don't populate the array states on the stack but instead it
> static const. Makes the object code smaller by 79 bytes.
>
> Before:
> text data bss dec hex filename
> 21309 8304 192 29805 746d drivers/net/ethernet/mellanox/mlx4/qp.o
>
> After:
> text data bss dec hex filename
> 21166 8368 192 29726 741e drivers/net/ethernet/mellanox/mlx4/qp.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlx4/qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <[email protected]>

2021-08-02 10:41:54

by Tariq Toukan

Subject: Re: [PATCH] net/mlx4: make the array states static const, makes object smaller

On 8/1/2021 6:37 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Don't populate the array states on the stack but instead it
> static const. Makes the object code smaller by 79 bytes.
>
> Before:
> text data bss dec hex filename
> 21309 8304 192 29805 746d drivers/net/ethernet/mellanox/mlx4/qp.o
>
> After:
> text data bss dec hex filename
> 21166 8368 192 29726 741e drivers/net/ethernet/mellanox/mlx4/qp.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlx4/qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/qp.c b/drivers/net/ethernet/mellanox/mlx4/qp.c
> index 427e7a31862c..2584bc038f94 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/qp.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/qp.c
> @@ -917,7 +917,7 @@ int mlx4_qp_to_ready(struct mlx4_dev *dev, struct mlx4_mtt *mtt,
> {
> int err;
> int i;
> - enum mlx4_qp_state states[] = {
> + static const enum mlx4_qp_state states[] = {
> MLX4_QP_STATE_RST,
> MLX4_QP_STATE_INIT,
> MLX4_QP_STATE_RTR,
>

Reviewed-by: Tariq Toukan <[email protected]>
Thanks for your patch.

Regards,
Tariq

2021-08-02 22:12:25

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net/mlx4: make the array states static const, makes object smaller

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sun, 1 Aug 2021 16:37:42 +0100 you wrote:
> From: Colin Ian King <[email protected]>
>
> Don't populate the array states on the stack but instead it
> static const. Makes the object code smaller by 79 bytes.
>
> Before:
> text data bss dec hex filename
> 21309 8304 192 29805 746d drivers/net/ethernet/mellanox/mlx4/qp.o
>
> [...]

Here is the summary with links:
- net/mlx4: make the array states static const, makes object smaller
https://git.kernel.org/netdev/net-next/c/7cdd0a89ec70

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html