2021-06-29 13:23:44

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] PCI: PCI_IXP4XX should depend on ARCH_IXP4XX

The Intel IXP4xx PCI controller is only present on Intel IXP4xx
XScale-based network processor SoCs. Hence add a dependency on
ARCH_IXP4XX, to prevent asking the user about this driver when
configuring a kernel without support for the XScale processor family.

Fixes: f7821b4934584824 ("PCI: ixp4xx: Add a new driver for IXP4xx")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/pci/controller/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 5e1e3796efa4e327..326f7d13024f9037 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -40,6 +40,7 @@ config PCI_FTPCI100
config PCI_IXP4XX
bool "Intel IXP4xx PCI controller"
depends on ARM && OF
+ depends on ARCH_IXP4XX || COMPILE_TEST
default ARCH_IXP4XX
help
Say Y here if you want support for the PCI host controller found
--
2.25.1


2021-06-30 00:27:14

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] PCI: PCI_IXP4XX should depend on ARCH_IXP4XX

On Tue, Jun 29, 2021 at 3:20 PM Geert Uytterhoeven
<[email protected]> wrote:

> The Intel IXP4xx PCI controller is only present on Intel IXP4xx
> XScale-based network processor SoCs. Hence add a dependency on
> ARCH_IXP4XX, to prevent asking the user about this driver when
> configuring a kernel without support for the XScale processor family.
>
> Fixes: f7821b4934584824 ("PCI: ixp4xx: Add a new driver for IXP4xx")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2021-07-23 15:14:40

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH] PCI: PCI_IXP4XX should depend on ARCH_IXP4XX

On Tue, 29 Jun 2021 15:20:45 +0200, Geert Uytterhoeven wrote:
> The Intel IXP4xx PCI controller is only present on Intel IXP4xx
> XScale-based network processor SoCs. Hence add a dependency on
> ARCH_IXP4XX, to prevent asking the user about this driver when
> configuring a kernel without support for the XScale processor family.

Applied to pci/misc, thanks!

[1/1] PCI: controller: PCI_IXP4XX should depend on ARCH_IXP4XX
https://git.kernel.org/lpieralisi/pci/c/9f1168cf26

Thanks,
Lorenzo