2024-04-30 19:46:02

by Mateusz Jończyk

[permalink] [raw]
Subject: [Regression] dmesg warnings after "i2c: smbus: Support up to 8 SPD EEPROMs"

Hello,

I have received a regression report on
commit 13e3a512a29001c ("i2c: smbus: Support up to 8 SPD EEPROMs")
as I was subscribed to some kernel Bugzilla thread and I'm posting it here
to make you aware of it.

This thread was

Bug 213345 - i801_smbus: Timeout waiting for interrupt, driver can't access SMBus

[email protected] on 2024-04-19 08:22:57 UTC wrote:
> I got similar issue on thinkpad X1 gen9 with latest 6.9.0-rc4+
> Git bisect the first bad commit is "13e3a512a29001c i2c: smbus: Support up to 8 SPD EEPROMs
> "
>
> modprobe without param:
> [ 1290.401393] i801_smbus 0000:00:1f.4: SPD Write Disable is set
> [ 1290.401486] i801_smbus 0000:00:1f.4: SMBus using PCI interrupt
> [ 1290.403340] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1290.403383] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1290.403410] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1290.403437] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1290.403465] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1290.403492] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1290.403519] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1290.403546] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>
> with param
> [ 1314.568785] i801_smbus 0000:00:1f.4: Interrupt disabled by user
> [ 1314.568837] i801_smbus 0000:00:1f.4: SPD Write Disable is set
> [ 1314.568894] i801_smbus 0000:00:1f.4: SMBus using po*lling
> [ 1314.570230] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1314.570257] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1314.570283] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1314.570310] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1314.570336] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1314.570362] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1314.570389] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> [ 1314.570415] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!

Link: https://bugzilla.kernel.org/show_bug.cgi?id=213345

The param mentioned was i2c-i801.disable_features=0x10, which disables interrupt usage
of this driver.

Please decide if this is serious enough to warrant a revert.

Greetings,
Mateusz



2024-05-01 07:28:02

by Wolfram Sang

[permalink] [raw]
Subject: Re: [Regression] dmesg warnings after "i2c: smbus: Support up to 8 SPD EEPROMs"


Adding Heiner...

On Tue, Apr 30, 2024 at 09:39:03PM +0200, Mateusz Jończyk wrote:
> Hello,
>
> I have received a regression report on
> commit 13e3a512a29001c ("i2c: smbus: Support up to 8 SPD EEPROMs")
> as I was subscribed to some kernel Bugzilla thread and I'm posting it here
> to make you aware of it.
>
> This thread was
>
> Bug 213345 - i801_smbus: Timeout waiting for interrupt, driver can't access SMBus
>
> [email protected] on 2024-04-19 08:22:57 UTC wrote:
> > I got similar issue on thinkpad X1 gen9 with latest 6.9.0-rc4+
> > Git bisect the first bad commit is "13e3a512a29001c i2c: smbus: Support up to 8 SPD EEPROMs
> > "
> >
> > modprobe without param:
> > [ 1290.401393] i801_smbus 0000:00:1f.4: SPD Write Disable is set
> > [ 1290.401486] i801_smbus 0000:00:1f.4: SMBus using PCI interrupt
> > [ 1290.403340] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1290.403383] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1290.403410] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1290.403437] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1290.403465] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1290.403492] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1290.403519] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1290.403546] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> >
> > with param
> > [ 1314.568785] i801_smbus 0000:00:1f.4: Interrupt disabled by user
> > [ 1314.568837] i801_smbus 0000:00:1f.4: SPD Write Disable is set
> > [ 1314.568894] i801_smbus 0000:00:1f.4: SMBus using po*lling
> > [ 1314.570230] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1314.570257] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1314.570283] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1314.570310] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1314.570336] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1314.570362] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1314.570389] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
> > [ 1314.570415] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=213345
>
> The param mentioned was i2c-i801.disable_features=0x10, which disables interrupt usage
> of this driver.
>
> Please decide if this is serious enough to warrant a revert.
>
> Greetings,
> Mateusz
>
>

Attachments:
(No filename) (2.48 kB)
 signature.asc (849.00 B)
 Download all attachments

2024-05-01 09:57:49

by Heiner Kallweit

[permalink] [raw]
Subject: Re: [Regression] dmesg warnings after "i2c: smbus: Support up to 8 SPD EEPROMs"

On 01.05.2024 09:27, Wolfram Sang wrote:
>
> Adding Heiner...
>
> On Tue, Apr 30, 2024 at 09:39:03PM +0200, Mateusz Jończyk wrote:
>> Hello,
>>
>> I have received a regression report on
>> commit 13e3a512a29001c ("i2c: smbus: Support up to 8 SPD EEPROMs")
>> as I was subscribed to some kernel Bugzilla thread and I'm posting it here
>> to make you aware of it.
>>
>> This thread was
>>
>> Bug 213345 - i801_smbus: Timeout waiting for interrupt, driver can't access SMBus
>>
>> [email protected] on 2024-04-19 08:22:57 UTC wrote:
>>> I got similar issue on thinkpad X1 gen9 with latest 6.9.0-rc4+
>>> Git bisect the first bad commit is "13e3a512a29001c i2c: smbus: Support up to 8 SPD EEPROMs
>>> "

Thanks for the report. Repeating what I just commented in bugzilla:

The mentioned commit showed up in 6.8 only, but the problem reports
date back to at least 5.12. Original bug report in bugzilla is from
2021. So I don't think this commit is the culprit.

What is the latest known good kernel version?
How about LTS version 6.6?

>>>
>>> modprobe without param:
>>> [ 1290.401393] i801_smbus 0000:00:1f.4: SPD Write Disable is set
>>> [ 1290.401486] i801_smbus 0000:00:1f.4: SMBus using PCI interrupt
>>> [ 1290.403340] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1290.403383] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1290.403410] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1290.403437] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1290.403465] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1290.403492] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1290.403519] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1290.403546] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>>
>>> with param
>>> [ 1314.568785] i801_smbus 0000:00:1f.4: Interrupt disabled by user
>>> [ 1314.568837] i801_smbus 0000:00:1f.4: SPD Write Disable is set
>>> [ 1314.568894] i801_smbus 0000:00:1f.4: SMBus using po*lling
>>> [ 1314.570230] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1314.570257] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1314.570283] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1314.570310] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1314.570336] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1314.570362] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1314.570389] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>> [ 1314.570415] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
>>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=213345
>>
>> The param mentioned was i2c-i801.disable_features=0x10, which disables interrupt usage
>> of this driver.
>>
>> Please decide if this is serious enough to warrant a revert.
>>
>> Greetings,
>> Mateusz
>>
>>
Heiner