On 31/05/2017 15:33, Marc Gonzalez wrote:
> +static int tango_pcie_probe(struct platform_device *pdev)
> +{
> + int ret = -EINVAL;
> + void __iomem *base;
> + struct resource *res;
> + struct tango_pcie *pcie;
> + struct device *dev = &pdev->dev;
> +
> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
> + pr_err("Tainting kernel... Use driver at your own risk\n");
> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
Hello Bjorn,
In v4, your only comment was
"[muxing config and mem spaces] is a major issue and possibly even
a security problem [which requires at least an error message and a
kernel taint].
Were there any other issues with the host bridge support?
Or is the HW quirk/bug too severe to mainline the driver?
(I would hate having to discard all that work though.)
Regards.
On 07/06/2017 10:19, Marc Gonzalez wrote:
> On 31/05/2017 15:33, Marc Gonzalez wrote:
>
>> +static int tango_pcie_probe(struct platform_device *pdev)
>> +{
>> + int ret = -EINVAL;
>> + void __iomem *base;
>> + struct resource *res;
>> + struct tango_pcie *pcie;
>> + struct device *dev = &pdev->dev;
>> +
>> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>> + pr_err("Tainting kernel... Use driver at your own risk\n");
>> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>
> Hello Bjorn,
>
> In v4, your only comment was
> "[muxing config and mem spaces] is a major issue and possibly even
> a security problem [which requires at least an error message and a
> kernel taint].
>
> Were there any other issues with the host bridge support?
Hello Bjorn,
I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
(AFAIU, all issues have been addressed as of v8 3/3.)
Rob has Acked patch 1/3 -- thanks Rob.
Assuming all issues with patch 2/3 have already been addressed,
then this driver can land in time for 4.13 right?
Regards.
On 19/06/17 15:50, Marc Gonzalez wrote:
> On 07/06/2017 10:19, Marc Gonzalez wrote:
>
>> On 31/05/2017 15:33, Marc Gonzalez wrote:
>>
>>> +static int tango_pcie_probe(struct platform_device *pdev)
>>> +{
>>> + int ret = -EINVAL;
>>> + void __iomem *base;
>>> + struct resource *res;
>>> + struct tango_pcie *pcie;
>>> + struct device *dev = &pdev->dev;
>>> +
>>> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>>> + pr_err("Tainting kernel... Use driver at your own risk\n");
>>> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>>
>> Hello Bjorn,
>>
>> In v4, your only comment was
>> "[muxing config and mem spaces] is a major issue and possibly even
>> a security problem [which requires at least an error message and a
>> kernel taint].
>>
>> Were there any other issues with the host bridge support?
>
> Hello Bjorn,
>
> I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
> (AFAIU, all issues have been addressed as of v8 3/3.)
Posting partial series is really not ideal, specially as you posted 3 of
them in less than 24 hours (and the latest was only 5 days ago).
The maintainer is not going to chase you about potentially missing
patches...
M.
--
Jazz is not dead. It just smells funny...
On 19/06/2017 17:58, Marc Zyngier wrote:
> On 19/06/17 15:50, Marc Gonzalez wrote:
>> On 07/06/2017 10:19, Marc Gonzalez wrote:
>>
>>> On 31/05/2017 15:33, Marc Gonzalez wrote:
>>>
>>>> +static int tango_pcie_probe(struct platform_device *pdev)
>>>> +{
>>>> + int ret = -EINVAL;
>>>> + void __iomem *base;
>>>> + struct resource *res;
>>>> + struct tango_pcie *pcie;
>>>> + struct device *dev = &pdev->dev;
>>>> +
>>>> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>>>> + pr_err("Tainting kernel... Use driver at your own risk\n");
>>>> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>>>
>>> Hello Bjorn,
>>>
>>> In v4, your only comment was
>>> "[muxing config and mem spaces] is a major issue and possibly even
>>> a security problem [which requires at least an error message and a
>>> kernel taint].
>>>
>>> Were there any other issues with the host bridge support?
>>
>> Hello Bjorn,
>>
>> I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
>> (AFAIU, all issues have been addressed as of v8 3/3.)
>
> Posting partial series is really not ideal, specially as you posted 3 of
> them in less than 24 hours (and the latest was only 5 days ago).
>
> The maintainer is not going to chase you about potentially missing
> patches...
So the best course would be posting a new series with all patches
bumped to v8 then?
Regards.
On 19/06/17 17:01, Marc Gonzalez wrote:
> On 19/06/2017 17:58, Marc Zyngier wrote:
>> On 19/06/17 15:50, Marc Gonzalez wrote:
>>> On 07/06/2017 10:19, Marc Gonzalez wrote:
>>>
>>>> On 31/05/2017 15:33, Marc Gonzalez wrote:
>>>>
>>>>> +static int tango_pcie_probe(struct platform_device *pdev)
>>>>> +{
>>>>> + int ret = -EINVAL;
>>>>> + void __iomem *base;
>>>>> + struct resource *res;
>>>>> + struct tango_pcie *pcie;
>>>>> + struct device *dev = &pdev->dev;
>>>>> +
>>>>> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>>>>> + pr_err("Tainting kernel... Use driver at your own risk\n");
>>>>> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>>>>
>>>> Hello Bjorn,
>>>>
>>>> In v4, your only comment was
>>>> "[muxing config and mem spaces] is a major issue and possibly even
>>>> a security problem [which requires at least an error message and a
>>>> kernel taint].
>>>>
>>>> Were there any other issues with the host bridge support?
>>>
>>> Hello Bjorn,
>>>
>>> I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
>>> (AFAIU, all issues have been addressed as of v8 3/3.)
>>
>> Posting partial series is really not ideal, specially as you posted 3 of
>> them in less than 24 hours (and the latest was only 5 days ago).
>>
>> The maintainer is not going to chase you about potentially missing
>> patches...
>
> So the best course would be posting a new series with all patches
> bumped to v8 then?
No, because there is still the ambiguity of *which* v8 that is. Post a
v9 that supersedes all the previously posted patches.
M.
--
Jazz is not dead. It just smells funny...
On 19/06/2017 16:50, Marc Gonzalez wrote:
> On 07/06/2017 10:19, Marc Gonzalez wrote:
>
>> On 31/05/2017 15:33, Marc Gonzalez wrote:
>>
>>> +static int tango_pcie_probe(struct platform_device *pdev)
>>> +{
>>> + int ret = -EINVAL;
>>> + void __iomem *base;
>>> + struct resource *res;
>>> + struct tango_pcie *pcie;
>>> + struct device *dev = &pdev->dev;
>>> +
>>> + pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
>>> + pr_err("Tainting kernel... Use driver at your own risk\n");
>>> + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
>>
>> Hello Bjorn,
>>
>> In v4, your only comment was
>> "[muxing config and mem spaces] is a major issue and possibly even
>> a security problem [which requires at least an error message and a
>> kernel taint].
>>
>> Were there any other issues with the host bridge support?
>
> Hello Bjorn,
>
> I imagine you are now only waiting for Marc Z's Ack of patch 3/3 ?
> (AFAIU, all issues have been addressed as of v8 3/3.)
>
> Rob has Acked patch 1/3 -- thanks Rob.
>
> Assuming all issues with patch 2/3 have already been addressed,
> then this driver can land in time for 4.13 right?
Hello Bjorn, Marc,
Patch series v9 supersedes all previously posted patches.
Regards.