Hi,
Here is round 3 of some trivial dynamic debug improvements.
v2 -> v3:
* Use a more clear example in the cli param examples
v1 -> v2:
* Use different example when showing misleading error message
* Justify dynamic debug scanning the whole command line
* Add patch removing ddebug_query
* Add patch improving cli param examples for dyndbg/$module.dyndbg
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/
Andrew Halaney (3):
dyndbg: make dyndbg a known cli param
dyndbg: Remove support for ddebug_query param
Documentation: dyndbg: Improve cli param examples
.../admin-guide/dynamic-debug-howto.rst | 13 ++++-----
.../admin-guide/kernel-parameters.txt | 5 ----
lib/dynamic_debug.c | 27 +++++--------------
3 files changed, 14 insertions(+), 31 deletions(-)
--
2.31.1
Hi Andrew,
Series looks good to me.
Acked-by: Jason Baron <[email protected]>
Thanks,
-Jason
On 9/20/21 4:54 PM, Andrew Halaney wrote:
> Hi,
>
> Here is round 3 of some trivial dynamic debug improvements.
>
> v2 -> v3:
> * Use a more clear example in the cli param examples
>
> v1 -> v2:
> * Use different example when showing misleading error message
> * Justify dynamic debug scanning the whole command line
> * Add patch removing ddebug_query
> * Add patch improving cli param examples for dyndbg/$module.dyndbg
>
> v2: https://urldefense.com/v3/__https://lore.kernel.org/all/[email protected]/__;!!GjvTz_vk!E6HzrtWvnWiM_KOORWtK46YQNqqO5npPrKi9LrU8F1CdWgS2w6dxfzi_clWo1Q$
> v1: https://urldefense.com/v3/__https://lore.kernel.org/all/[email protected]/__;!!GjvTz_vk!E6HzrtWvnWiM_KOORWtK46YQNqqO5npPrKi9LrU8F1CdWgS2w6dxfzhcL6__NA$
>
> Andrew Halaney (3):
> dyndbg: make dyndbg a known cli param
> dyndbg: Remove support for ddebug_query param
> Documentation: dyndbg: Improve cli param examples
>
> .../admin-guide/dynamic-debug-howto.rst | 13 ++++-----
> .../admin-guide/kernel-parameters.txt | 5 ----
> lib/dynamic_debug.c | 27 +++++--------------
> 3 files changed, 14 insertions(+), 31 deletions(-)
>
Adding Greg to this (should have added him earlier)
Greg, if you are ok with this series, we'd like to have it added
to -next.
Thanks,
-Jason
On 9/20/21 4:54 PM, Andrew Halaney wrote:
> Hi,
>
> Here is round 3 of some trivial dynamic debug improvements.
>
> v2 -> v3:
> * Use a more clear example in the cli param examples
>
> v1 -> v2:
> * Use different example when showing misleading error message
> * Justify dynamic debug scanning the whole command line
> * Add patch removing ddebug_query
> * Add patch improving cli param examples for dyndbg/$module.dyndbg
>
> v2: https://urldefense.com/v3/__https://lore.kernel.org/all/[email protected]/__;!!GjvTz_vk!E6HzrtWvnWiM_KOORWtK46YQNqqO5npPrKi9LrU8F1CdWgS2w6dxfzi_clWo1Q$
> v1: https://urldefense.com/v3/__https://lore.kernel.org/all/[email protected]/__;!!GjvTz_vk!E6HzrtWvnWiM_KOORWtK46YQNqqO5npPrKi9LrU8F1CdWgS2w6dxfzhcL6__NA$
>
> Andrew Halaney (3):
> dyndbg: make dyndbg a known cli param
> dyndbg: Remove support for ddebug_query param
> Documentation: dyndbg: Improve cli param examples
>
> .../admin-guide/dynamic-debug-howto.rst | 13 ++++-----
> .../admin-guide/kernel-parameters.txt | 5 ----
> lib/dynamic_debug.c | 27 +++++--------------
> 3 files changed, 14 insertions(+), 31 deletions(-)
>
On Fri, Oct 08, 2021 at 11:58:57AM -0400, Jason Baron wrote:
> Adding Greg to this (should have added him earlier)
>
> Greg, if you are ok with this series, we'd like to have it added
> to -next.
What series?
Have a pointer to it? It would help if it was actually sent to me if
people want it applied...
thanks,
greg k-h
On Fri, Oct 08, 2021 at 06:01:33PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 08, 2021 at 11:58:57AM -0400, Jason Baron wrote:
> > Adding Greg to this (should have added him earlier)
> >
> > Greg, if you are ok with this series, we'd like to have it added
> > to -next.
>
> What series?
>
> Have a pointer to it? It would help if it was actually sent to me if
> people want it applied...
>
> thanks,
>
> greg k-h
>
Sorry Greg, that's probably my bad.. still getting used to the kernel's
workflow.
Here's the lore link: https://lore.kernel.org/all/[email protected]/
Did I do something silly when sending the patches? I basically
just added everyone manually when using git send-email.
I found who to add via:
ahalaney@halaneylaptop ~/git/linux (git)-[master] % ./scripts/get_maintainer.pl 0002-dyndbg-Remove-support-for-ddebug_query-param.patch :(
Jonathan Corbet <[email protected]> (maintainer:DOCUMENTATION,commit_signer:1/2=50%)
Jason Baron <[email protected]> (maintainer:DYNAMIC DEBUG)
Martin Kepplinger <[email protected]> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/3=33%,removed_lines:1/5=20%)
Andrew Halaney <[email protected]> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:2/3=67%,removed_lines:4/5=80%)
"Paul E. McKenney" <[email protected]> (commit_signer:14/89=16%,authored:7/89=8%,added_lines:44/527=8%)
Thomas Gleixner <[email protected]> (commit_signer:11/89=12%)
Andrew Morton <[email protected]> (commit_signer:11/89=12%)
Peter Zijlstra <[email protected]> (commit_signer:8/89=9%,removed_lines:13/137=9%)
Will Deacon <[email protected]> (commit_signer:7/89=8%)
"Maciej W. Rozycki" <[email protected]> (added_lines:90/527=17%)
Muchun Song <[email protected]> (added_lines:28/527=5%)
Viresh Kumar <[email protected]> (removed_lines:14/137=10%)
Robin Murphy <[email protected]> (removed_lines:13/137=9%)
Randy Dunlap <[email protected]> (removed_lines:10/137=7%)
Lu Baolu <[email protected]> (removed_lines:10/137=7%)
[email protected] (open list:DOCUMENTATION)
[email protected] (open list)
per patch, and I just hit the maintainers and the lists specified
since I figured the commit_signers don't care. Did I goof up?
Thanks,
Andrew
On Fri, Oct 08, 2021 at 11:27:07AM -0500, Andrew Halaney wrote:
> On Fri, Oct 08, 2021 at 06:01:33PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Oct 08, 2021 at 11:58:57AM -0400, Jason Baron wrote:
> > > Adding Greg to this (should have added him earlier)
> > >
> > > Greg, if you are ok with this series, we'd like to have it added
> > > to -next.
> >
> > What series?
> >
> > Have a pointer to it? It would help if it was actually sent to me if
> > people want it applied...
> >
> > thanks,
> >
> > greg k-h
> >
>
> Sorry Greg, that's probably my bad.. still getting used to the kernel's
> workflow.
>
> Here's the lore link: https://lore.kernel.org/all/[email protected]/
>
> Did I do something silly when sending the patches? I basically
> just added everyone manually when using git send-email.
>
> I found who to add via:
>
> ahalaney@halaneylaptop ~/git/linux (git)-[master] % ./scripts/get_maintainer.pl 0002-dyndbg-Remove-support-for-ddebug_query-param.patch :(
> Jonathan Corbet <[email protected]> (maintainer:DOCUMENTATION,commit_signer:1/2=50%)
> Jason Baron <[email protected]> (maintainer:DYNAMIC DEBUG)
> Martin Kepplinger <[email protected]> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/3=33%,removed_lines:1/5=20%)
> Andrew Halaney <[email protected]> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:2/3=67%,removed_lines:4/5=80%)
> "Paul E. McKenney" <[email protected]> (commit_signer:14/89=16%,authored:7/89=8%,added_lines:44/527=8%)
> Thomas Gleixner <[email protected]> (commit_signer:11/89=12%)
> Andrew Morton <[email protected]> (commit_signer:11/89=12%)
> Peter Zijlstra <[email protected]> (commit_signer:8/89=9%,removed_lines:13/137=9%)
> Will Deacon <[email protected]> (commit_signer:7/89=8%)
> "Maciej W. Rozycki" <[email protected]> (added_lines:90/527=17%)
> Muchun Song <[email protected]> (added_lines:28/527=5%)
> Viresh Kumar <[email protected]> (removed_lines:14/137=10%)
> Robin Murphy <[email protected]> (removed_lines:13/137=9%)
> Randy Dunlap <[email protected]> (removed_lines:10/137=7%)
> Lu Baolu <[email protected]> (removed_lines:10/137=7%)
> [email protected] (open list:DOCUMENTATION)
> [email protected] (open list)
>
>
> per patch, and I just hit the maintainers and the lists specified
> since I figured the commit_signers don't care. Did I goof up?
No, that's all correct. It's up to the maintainers to then route your
patches to the proper tree.
If they want me to take them, great, I'll be glad to do so, but I need
them to send them to me :)
thanks,
greg k-h
On 10/13/21 7:35 AM, Greg Kroah-Hartman wrote:
> On Fri, Oct 08, 2021 at 11:27:07AM -0500, Andrew Halaney wrote:
>> On Fri, Oct 08, 2021 at 06:01:33PM +0200, Greg Kroah-Hartman wrote:
>>> On Fri, Oct 08, 2021 at 11:58:57AM -0400, Jason Baron wrote:
>>>> Adding Greg to this (should have added him earlier)
>>>>
>>>> Greg, if you are ok with this series, we'd like to have it added
>>>> to -next.
>>>
>>> What series?
>>>
>>> Have a pointer to it? It would help if it was actually sent to me if
>>> people want it applied...
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>
>> Sorry Greg, that's probably my bad.. still getting used to the kernel's
>> workflow.
>>
>> Here's the lore link: https://urldefense.com/v3/__https://lore.kernel.org/all/[email protected]/__;!!GjvTz_vk!A7QQa1yGOtgSmhzn52NLhZuRbLxxMCyl17_8RiqsehjeAG2AAsYl7bgWgK15Pw$
>>
>> Did I do something silly when sending the patches? I basically
>> just added everyone manually when using git send-email.
>>
>> I found who to add via:
>>
>> ahalaney@halaneylaptop ~/git/linux (git)-[master] % ./scripts/get_maintainer.pl 0002-dyndbg-Remove-support-for-ddebug_query-param.patch :(
>> Jonathan Corbet <[email protected]> (maintainer:DOCUMENTATION,commit_signer:1/2=50%)
>> Jason Baron <[email protected]> (maintainer:DYNAMIC DEBUG)
>> Martin Kepplinger <[email protected]> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:1/3=33%,removed_lines:1/5=20%)
>> Andrew Halaney <[email protected]> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:2/3=67%,removed_lines:4/5=80%)
>> "Paul E. McKenney" <[email protected]> (commit_signer:14/89=16%,authored:7/89=8%,added_lines:44/527=8%)
>> Thomas Gleixner <[email protected]> (commit_signer:11/89=12%)
>> Andrew Morton <[email protected]> (commit_signer:11/89=12%)
>> Peter Zijlstra <[email protected]> (commit_signer:8/89=9%,removed_lines:13/137=9%)
>> Will Deacon <[email protected]> (commit_signer:7/89=8%)
>> "Maciej W. Rozycki" <[email protected]> (added_lines:90/527=17%)
>> Muchun Song <[email protected]> (added_lines:28/527=5%)
>> Viresh Kumar <[email protected]> (removed_lines:14/137=10%)
>> Robin Murphy <[email protected]> (removed_lines:13/137=9%)
>> Randy Dunlap <[email protected]> (removed_lines:10/137=7%)
>> Lu Baolu <[email protected]> (removed_lines:10/137=7%)
>> [email protected] (open list:DOCUMENTATION)
>> [email protected] (open list)
>>
>>
>> per patch, and I just hit the maintainers and the lists specified
>> since I figured the commit_signers don't care. Did I goof up?
>
> No, that's all correct. It's up to the maintainers to then route your
> patches to the proper tree.
>
> If they want me to take them, great, I'll be glad to do so, but I need
> them to send them to me :)
Ok, I will re-send the series to Greg.
Thanks,
-Jason