This series fixes issues hight lighted by dtbs_check on STM32 devicetrees.
The patches has been developped on top of v5.7-rc4 tag.
Benjamin Gaignard (15):
ARM: dts: stm32: remove useless interrupt-names property on stm32f429
ARM: dts: stm32: update pwm pinctrl node names for stm32f4
ARM: dts: stm32: update led nodes names for stm32f249-disco
ARM: dts: stm32: update led nodes names for stm32f469-disco
ARM: dts: stm32: remove useless interrupt-names property on stm32f746
ARM: dts: stm32: update led nodes names for stm32f429-eval
ARM: dts: stm32: update led nodes names for stm32f769-disco
ARM: dts: stm32: update led nodes names for stm32f746-eval
ARM: dts: stm32: remove useless interrupt-names property on stm32f743
ARM: dts: stm32: Update nodes names for stm32h743 pinctrl
ARM: dts: stm32: Update nodes names for stm32mp15 pinctrl
ARM: dts: stm32: Add missing #address and #size cells on spi node for
stm32mp151
ARM: dts: stm32: update led nodes names for stm32f746-eval
dt-bindings: pinctrl: stm32: Add missing interrupts property
dt-bindings: usb: dwc2: Fix issues for stm32mp15x SoC
.../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 +++
Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++--
arch/arm/boot/dts/stm32429i-eval.dts | 8 ++++----
arch/arm/boot/dts/stm32746g-eval.dts | 8 ++++----
arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 4 ++--
arch/arm/boot/dts/stm32f429-disco.dts | 4 ++--
arch/arm/boot/dts/stm32f429.dtsi | 1 -
arch/arm/boot/dts/stm32f469-disco.dts | 8 ++++----
arch/arm/boot/dts/stm32f746.dtsi | 1 -
arch/arm/boot/dts/stm32f769-disco.dts | 4 ++--
arch/arm/boot/dts/stm32h743-pinctrl.dtsi | 10 +++++-----
arch/arm/boot/dts/stm32h743.dtsi | 1 -
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 6 +++---
arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 2 +-
15 files changed, 36 insertions(+), 32 deletions(-)
--
2.15.0
Driver doesn't use interrupt's name to get it so remove it from
the node.
Signed-off-by: Benjamin Gaignard <[email protected]>
---
arch/arm/boot/dts/stm32f746.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index 93c063796780..5d69a0c653eb 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -304,7 +304,6 @@
assigned-clock-parents = <&rcc 1 CLK_LSE>;
interrupt-parent = <&exti>;
interrupts = <17 1>;
- interrupt-names = "alarm";
st,syscfg = <&pwrcfg 0x00 0x100>;
status = "disabled";
};
--
2.15.0
Update led nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <[email protected]>
---
arch/arm/boot/dts/stm32429i-eval.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
index c27fa355e5ab..4115e7e2b739 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -104,17 +104,17 @@
leds {
compatible = "gpio-leds";
- green {
+ led-green {
gpios = <&gpiog 6 1>;
linux,default-trigger = "heartbeat";
};
- orange {
+ led-orange {
gpios = <&gpiog 7 1>;
};
- red {
+ led-red {
gpios = <&gpiog 10 1>;
};
- blue {
+ led-blue {
gpios = <&gpiog 12 1>;
};
};
--
2.15.0
Correct the compatible list for stm32mp15x SoC.
Fix the name of the stm32mp15x dedicated supply to be aligned with
what the driver use.
Signed-off-by: Benjamin Gaignard <[email protected]>
---
Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 0d6d850a7f17..1357b861310d 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -44,7 +44,9 @@ properties:
- const: st,stm32f4x9-hsotg
- const: st,stm32f7-hsotg
- const: st,stm32mp15-fsotg
- - const: st,stm32mp15-hsotg
+ - items:
+ - const: st,stm32mp15-hsotg
+ - const: snps,dwc2
- const: samsung,s3c6400-hsotg
reg:
@@ -90,7 +92,7 @@ properties:
vusb_a-supply:
description: phandle to voltage regulator of analog section.
- vusb33d-supply:
+ usb33d-supply:
description: reference to the VBUS and ID sensing comparators supply, in
order to perform OTG operation, used on STM32MP15 SoCs.
--
2.15.0
Fix the nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <[email protected]>
---
arch/arm/boot/dts/stm32h743-pinctrl.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/stm32h743-pinctrl.dtsi b/arch/arm/boot/dts/stm32h743-pinctrl.dtsi
index e44e7baa3f17..fa5dcb6a5fdd 100644
--- a/arch/arm/boot/dts/stm32h743-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32h743-pinctrl.dtsi
@@ -163,7 +163,7 @@
#interrupt-cells = <2>;
};
- i2c1_pins_a: i2c1@0 {
+ i2c1_pins_a: i2c1-0 {
pins {
pinmux = <STM32_PINMUX('B', 6, AF4)>, /* I2C1_SCL */
<STM32_PINMUX('B', 7, AF4)>; /* I2C1_SDA */
@@ -173,7 +173,7 @@
};
};
- ethernet_rmii: rmii@0 {
+ ethernet_rmii: rmii-0 {
pins {
pinmux = <STM32_PINMUX('G', 11, AF11)>,
<STM32_PINMUX('G', 13, AF11)>,
@@ -256,7 +256,7 @@
};
};
- usart1_pins: usart1@0 {
+ usart1_pins: usart1-0 {
pins1 {
pinmux = <STM32_PINMUX('B', 14, AF4)>; /* USART1_TX */
bias-disable;
@@ -269,7 +269,7 @@
};
};
- usart2_pins: usart2@0 {
+ usart2_pins: usart2-0 {
pins1 {
pinmux = <STM32_PINMUX('D', 5, AF7)>; /* USART2_TX */
bias-disable;
@@ -282,7 +282,7 @@
};
};
- usbotg_hs_pins_a: usbotg-hs@0 {
+ usbotg_hs_pins_a: usbotg-hs-0 {
pins {
pinmux = <STM32_PINMUX('H', 4, AF10)>, /* ULPI_NXT */
<STM32_PINMUX('I', 11, AF10)>, /* ULPI_DIR> */
--
2.15.0
Rename pwm pinctrl nodes name to matching with yaml bindings
requirements.
Signed-off-by: Benjamin Gaignard <[email protected]>
---
arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
index 392fa143ce07..031caaf40e89 100644
--- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
@@ -257,7 +257,7 @@
};
};
- pwm1_pins: pwm-1 {
+ pwm1_pins: pwm1-0 {
pins {
pinmux = <STM32_PINMUX('A', 8, AF1)>, /* TIM1_CH1 */
<STM32_PINMUX('B', 13, AF1)>, /* TIM1_CH1N */
@@ -265,7 +265,7 @@
};
};
- pwm3_pins: pwm-3 {
+ pwm3_pins: pwm3-0 {
pins {
pinmux = <STM32_PINMUX('B', 4, AF2)>, /* TIM3_CH1 */
<STM32_PINMUX('B', 5, AF2)>; /* TIM3_CH2 */
--
2.15.0
Driver doesn't use interrupt's name to get it so remove it from
the node.
Signed-off-by: Benjamin Gaignard <[email protected]>
---
arch/arm/boot/dts/stm32f429.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
index d7770699feb5..3537430fd4a3 100644
--- a/arch/arm/boot/dts/stm32f429.dtsi
+++ b/arch/arm/boot/dts/stm32f429.dtsi
@@ -322,7 +322,6 @@
assigned-clock-parents = <&rcc 1 CLK_LSE>;
interrupt-parent = <&exti>;
interrupts = <17 1>;
- interrupt-names = "alarm";
st,syscfg = <&pwrcfg 0x00 0x100>;
status = "disabled";
};
--
2.15.0
Update led nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <[email protected]>
---
arch/arm/boot/dts/stm32f469-disco.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/stm32f469-disco.dts b/arch/arm/boot/dts/stm32f469-disco.dts
index 9397db0c43de..2e1b3bbbe4b5 100644
--- a/arch/arm/boot/dts/stm32f469-disco.dts
+++ b/arch/arm/boot/dts/stm32f469-disco.dts
@@ -89,17 +89,17 @@
leds {
compatible = "gpio-leds";
- green {
+ led-green {
gpios = <&gpiog 6 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};
- orange {
+ led-orange {
gpios = <&gpiod 4 GPIO_ACTIVE_LOW>;
};
- red {
+ led-red {
gpios = <&gpiod 5 GPIO_ACTIVE_LOW>;
};
- blue {
+ led-blue {
gpios = <&gpiok 3 GPIO_ACTIVE_LOW>;
};
};
--
2.15.0
Update led nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <[email protected]>
---
arch/arm/boot/dts/stm32f769-disco.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/stm32f769-disco.dts b/arch/arm/boot/dts/stm32f769-disco.dts
index 1626e00bb2cb..0ce7fbc20fa4 100644
--- a/arch/arm/boot/dts/stm32f769-disco.dts
+++ b/arch/arm/boot/dts/stm32f769-disco.dts
@@ -66,11 +66,11 @@
leds {
compatible = "gpio-leds";
- green {
+ led-green {
gpios = <&gpioj 5 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
};
- red {
+ led-red {
gpios = <&gpioj 13 GPIO_ACTIVE_HIGH>;
};
};
--
2.15.0
Update led nodes names to be aligned with yaml description
Signed-off-by: Benjamin Gaignard <[email protected]>
---
arch/arm/boot/dts/stm32746g-eval.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/stm32746g-eval.dts b/arch/arm/boot/dts/stm32746g-eval.dts
index 4ea3f98dd275..ca8c192449ee 100644
--- a/arch/arm/boot/dts/stm32746g-eval.dts
+++ b/arch/arm/boot/dts/stm32746g-eval.dts
@@ -66,17 +66,17 @@
leds {
compatible = "gpio-leds";
- green {
+ led-green {
gpios = <&gpiof 10 1>;
linux,default-trigger = "heartbeat";
};
- orange {
+ led-orange {
gpios = <&stmfx_pinctrl 17 1>;
};
- red {
+ led-red {
gpios = <&gpiob 7 1>;
};
- blue {
+ led-blue {
gpios = <&stmfx_pinctrl 19 1>;
};
};
--
2.15.0
Hi Benjamin
On 5/13/20 4:59 PM, Benjamin Gaignard wrote:
> This series fixes issues hight lighted by dtbs_check on STM32 devicetrees.
> The patches has been developped on top of v5.7-rc4 tag.
>
> Benjamin Gaignard (15):
> ARM: dts: stm32: remove useless interrupt-names property on stm32f429
> ARM: dts: stm32: update pwm pinctrl node names for stm32f4
> ARM: dts: stm32: update led nodes names for stm32f249-disco
> ARM: dts: stm32: update led nodes names for stm32f469-disco
> ARM: dts: stm32: remove useless interrupt-names property on stm32f746
> ARM: dts: stm32: update led nodes names for stm32f429-eval
> ARM: dts: stm32: update led nodes names for stm32f769-disco
> ARM: dts: stm32: update led nodes names for stm32f746-eval
> ARM: dts: stm32: remove useless interrupt-names property on stm32f743
> ARM: dts: stm32: Update nodes names for stm32h743 pinctrl
> ARM: dts: stm32: Update nodes names for stm32mp15 pinctrl
> ARM: dts: stm32: Add missing #address and #size cells on spi node for
> stm32mp151
> ARM: dts: stm32: update led nodes names for stm32f746-eval
> dt-bindings: pinctrl: stm32: Add missing interrupts property
> dt-bindings: usb: dwc2: Fix issues for stm32mp15x SoC
For dts(i) part, it looks good to me. I let Rob to review before taking
the whole series.
thanks
alex
>
> .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 +++
> Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++--
> arch/arm/boot/dts/stm32429i-eval.dts | 8 ++++----
> arch/arm/boot/dts/stm32746g-eval.dts | 8 ++++----
> arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 4 ++--
> arch/arm/boot/dts/stm32f429-disco.dts | 4 ++--
> arch/arm/boot/dts/stm32f429.dtsi | 1 -
> arch/arm/boot/dts/stm32f469-disco.dts | 8 ++++----
> arch/arm/boot/dts/stm32f746.dtsi | 1 -
> arch/arm/boot/dts/stm32f769-disco.dts | 4 ++--
> arch/arm/boot/dts/stm32h743-pinctrl.dtsi | 10 +++++-----
> arch/arm/boot/dts/stm32h743.dtsi | 1 -
> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 6 +++---
> arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
> arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 2 +-
> 15 files changed, 36 insertions(+), 32 deletions(-)
>
On Wed, 13 May 2020 16:59:35 +0200, Benjamin Gaignard wrote:
> Correct the compatible list for stm32mp15x SoC.
> Fix the name of the stm32mp15x dedicated supply to be aligned with
> what the driver use.
>
> Signed-off-by: Benjamin Gaignard <[email protected]>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
Hi Benjamin
On 5/13/20 4:59 PM, Benjamin Gaignard wrote:
> This series fixes issues hight lighted by dtbs_check on STM32 devicetrees.
> The patches has been developped on top of v5.7-rc4 tag.
>
> Benjamin Gaignard (15):
> ARM: dts: stm32: remove useless interrupt-names property on stm32f429
> ARM: dts: stm32: update pwm pinctrl node names for stm32f4
> ARM: dts: stm32: update led nodes names for stm32f249-disco
> ARM: dts: stm32: update led nodes names for stm32f469-disco
> ARM: dts: stm32: remove useless interrupt-names property on stm32f746
> ARM: dts: stm32: update led nodes names for stm32f429-eval
> ARM: dts: stm32: update led nodes names for stm32f769-disco
> ARM: dts: stm32: update led nodes names for stm32f746-eval
> ARM: dts: stm32: remove useless interrupt-names property on stm32f743
> ARM: dts: stm32: Update nodes names for stm32h743 pinctrl
> ARM: dts: stm32: Update nodes names for stm32mp15 pinctrl
> ARM: dts: stm32: Add missing #address and #size cells on spi node for
> stm32mp151
> ARM: dts: stm32: update led nodes names for stm32f746-eval
> dt-bindings: pinctrl: stm32: Add missing interrupts property
> dt-bindings: usb: dwc2: Fix issues for stm32mp15x SoC
>
> .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 +++
> Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++--
> arch/arm/boot/dts/stm32429i-eval.dts | 8 ++++----
> arch/arm/boot/dts/stm32746g-eval.dts | 8 ++++----
> arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 4 ++--
> arch/arm/boot/dts/stm32f429-disco.dts | 4 ++--
> arch/arm/boot/dts/stm32f429.dtsi | 1 -
> arch/arm/boot/dts/stm32f469-disco.dts | 8 ++++----
> arch/arm/boot/dts/stm32f746.dtsi | 1 -
> arch/arm/boot/dts/stm32f769-disco.dts | 4 ++--
> arch/arm/boot/dts/stm32h743-pinctrl.dtsi | 10 +++++-----
> arch/arm/boot/dts/stm32h743.dtsi | 1 -
> arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 6 +++---
> arch/arm/boot/dts/stm32mp151.dtsi | 2 ++
> arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 2 +-
> 15 files changed, 36 insertions(+), 32 deletions(-)
>
Series applied on stm32-next. Note that changes in patch 11 were already
present thanks to another patch and patch 14 has already been taken by
Linus.
Regards
Alex