Hi all,
Commit
9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> Commit
>
> 9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")
>
> is missing a Signed-off-by from its committer.
Thanks for the report.
What script do you use to find those? I guess I should check for
missing signoffs as well when pulling a branch.
Patrice, I've dropped the merge now, and picked up the one
patch in it directly, with my signoff. This should fix the issue this
time, but please make sure you always sign off patches when
you apply them from the list.
Arnd
Hi Arnd,
On Thu, 15 Mar 2018 22:06:29 +0100 Arnd Bergmann <[email protected]> wrote:
>
> What script do you use to find those? I guess I should check for
> missing signoffs as well when pulling a branch.
See below. You can give it any commit range you would give e.g. gitk.
I run this using he ranges reported by the "git fetch" for each tree
each day.
--
Cheers,
Stephen Rothwell
#!/bin/bash
if [ "$#" -lt 1 ]; then
printf "Usage: %s <commit range>\n", "$0" 1>&2
exit 1
fi
commits=$(git rev-list --no-merges "$@")
if [ -z "$commits" ]; then
printf "No commits\n"
exit 0
fi
for c in $commits; do
ae=$(git log -1 --format='%ae' "$c")
aE=$(git log -1 --format='%aE' "$c")
an=$(git log -1 --format='%an' "$c")
aN=$(git log -1 --format='%aN' "$c")
ce=$(git log -1 --format='%ce' "$c")
cE=$(git log -1 --format='%cE' "$c")
cn=$(git log -1 --format='%cn' "$c")
cN=$(git log -1 --format='%cN' "$c")
sob=$(git log -1 --format='%b' "$c" | grep -i '^[[:space:]]*Signed-off-by:')
am=false
cm=false
grep -i -q "<$ae>" <<<"$sob" ||
grep -i -q "<$aE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$an[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$aN[[:space:]]*<" <<<"$sob" ||
am=true
grep -i -q "<$ce>" <<<"$sob" ||
grep -i -q "<$cE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cn[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cN[[:space:]]*<" <<<"$sob" ||
cm=true
if "$am" || "$cm"; then
printf "Commit %s\n" "$c"
"$am" && printf "\tauthor SOB missing\n"
"$cm" && printf "\tcommitter SOB missing\n"
printf "%s %s\n%s\n" "$ae" "$ce" "$sob"
fi
done
exec gitk "$@"
Hi Arnd, Stephen
On 03/15/2018 10:06 PM, Arnd Bergmann wrote:
> On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell <[email protected]> wrote:
>> Hi all,
>>
>> Commit
>>
>> 9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")
>>
>> is missing a Signed-off-by from its committer.
>
> Thanks for the report.
>
> What script do you use to find those? I guess I should check for
> missing signoffs as well when pulling a branch.
>
> Patrice, I've dropped the merge now, and picked up the one
> patch in it directly, with my signoff. This should fix the issue this
> time, but please make sure you always sign off patches when
> you apply them from the list.
>
> Arnd
>
Ok i will update my script on my side with Stephen's script to avoid
this in the future.
Thanks
Patrice
On 16/03/2018 at 07:34:06 +0000, Patrice CHOTARD wrote:
> Hi Arnd, Stephen
>
> On 03/15/2018 10:06 PM, Arnd Bergmann wrote:
> > On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell <[email protected]> wrote:
> >> Hi all,
> >>
> >> Commit
> >>
> >> 9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")
> >>
> >> is missing a Signed-off-by from its committer.
> >
> > Thanks for the report.
> >
> > What script do you use to find those? I guess I should check for
> > missing signoffs as well when pulling a branch.
> >
> > Patrice, I've dropped the merge now, and picked up the one
> > patch in it directly, with my signoff. This should fix the issue this
> > time, but please make sure you always sign off patches when
> > you apply them from the list.
> >
> > Arnd
> >
>
> Ok i will update my script on my side with Stephen's script to avoid
> this in the future.
>
FWIW, last time this happened in the at91 tree, I've switched to use
Stephen's script as a pre-push hook:
https://raw.githubusercontent.com/alexandrebelloni/tools/master/pre-push_signed-off
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
On 03/22/2018 10:01 PM, Alexandre Belloni wrote:
> On 16/03/2018 at 07:34:06 +0000, Patrice CHOTARD wrote:
>> Hi Arnd, Stephen
>>
>> On 03/15/2018 10:06 PM, Arnd Bergmann wrote:
>>> On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell <[email protected]> wrote:
>>>> Hi all,
>>>>
>>>> Commit
>>>>
>>>> 9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")
>>>>
>>>> is missing a Signed-off-by from its committer.
>>>
>>> Thanks for the report.
>>>
>>> What script do you use to find those? I guess I should check for
>>> missing signoffs as well when pulling a branch.
>>>
>>> Patrice, I've dropped the merge now, and picked up the one
>>> patch in it directly, with my signoff. This should fix the issue this
>>> time, but please make sure you always sign off patches when
>>> you apply them from the list.
>>>
>>> Arnd
>>>
>>
>> Ok i will update my script on my side with Stephen's script to avoid
>> this in the future.
>>
>
> FWIW, last time this happened in the at91 tree, I've switched to use
> Stephen's script as a pre-push hook:
> https://raw.githubusercontent.com/alexandrebelloni/tools/master/pre-push_signed-off
>
>
Thanks Alexandre
Patrice