2011-02-04 12:24:01

by Vasily Kulikov

Subject: [PATCH 13/20] net: can: janz-ican3: world-writable sysfs termination file

Don't allow everybody to set terminator via sysfs.

Signed-off-by: Vasiliy Kulikov <[email protected]>
---
Compile tested only.

drivers/net/can/janz-ican3.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c
index b9a6d7a..366f5cc 100644
--- a/drivers/net/can/janz-ican3.c
+++ b/drivers/net/can/janz-ican3.c
@@ -1618,7 +1618,7 @@ static ssize_t ican3_sysfs_set_term(struct device *dev,
return count;
}

-static DEVICE_ATTR(termination, S_IWUGO | S_IRUGO, ican3_sysfs_show_term,
+static DEVICE_ATTR(termination, S_IWUSR | S_IRUGO, ican3_sysfs_show_term,
ican3_sysfs_set_term);

static struct attribute *ican3_sysfs_attrs[] = {
--
1.7.0.4

2011-02-04 21:06:08

by David Miller

Subject: Re: [PATCH 13/20] net: can: janz-ican3: world-writable sysfs termination file

From: Vasiliy Kulikov <[email protected]>
Date: Fri, 4 Feb 2011 15:23:53 +0300

> Don't allow everybody to set terminator via sysfs.
>
> Signed-off-by: Vasiliy Kulikov <[email protected]>

Applied.