2018-07-18 19:57:16

by Krzysztof Kozlowski

Subject: [PATCH] drm/exynos/mixer: Remove unused local variable priv

Remove local variable 'priv' to fix GCC warning:

drivers/gpu/drm/exynos/exynos_mixer.c: In function 'mixer_initialize':
drivers/gpu/drm/exynos/exynos_mixer.c:840:29: warning: variable 'priv' set but not used [-Wunused-but-set-variable]

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/exynos/exynos_mixer.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
index 272c79f5f5bf..b86ae2ab9590 100644
--- a/drivers/gpu/drm/exynos/exynos_mixer.c
+++ b/drivers/gpu/drm/exynos/exynos_mixer.c
@@ -837,8 +837,6 @@ static int mixer_initialize(struct mixer_context *mixer_ctx,
struct drm_device *drm_dev)
{
int ret;
- struct exynos_drm_private *priv;
- priv = drm_dev->dev_private;

mixer_ctx->drm_dev = drm_dev;

--
2.14.1

2018-07-18 20:24:21

by Tobias Jakobi

Subject: Re: [PATCH] drm/exynos/mixer: Remove unused local variable priv

Hello Krzysztof,

looks good to me!

Reviewed-by: Tobias Jakobi <[email protected]>

- Tobias


Krzysztof Kozlowski wrote:
> Remove local variable 'priv' to fix GCC warning:
>
> drivers/gpu/drm/exynos/exynos_mixer.c: In function 'mixer_initialize':
> drivers/gpu/drm/exynos/exynos_mixer.c:840:29: warning: variable 'priv' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/gpu/drm/exynos/exynos_mixer.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
> index 272c79f5f5bf..b86ae2ab9590 100644
> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
> @@ -837,8 +837,6 @@ static int mixer_initialize(struct mixer_context *mixer_ctx,
> struct drm_device *drm_dev)
> {
> int ret;
> - struct exynos_drm_private *priv;
> - priv = drm_dev->dev_private;
>
> mixer_ctx->drm_dev = drm_dev;
>
>