2024-04-24 17:43:57

by Rayyan Ansari

[permalink] [raw]
Subject: [PATCH] ARM: dts: qcom: msm8226-microsoft-common: Enable smbb explicitly

Enable the smbb node explicitly for MSM8x26 Lumia devices. These devices
rely on the smbb driver in order to detect USB state.

It seems that this was accidentally missed in the commit that this
fixes.

Fixes: c9c8179d0ccd ("ARM: dts: qcom: Disable pm8941 & pm8226 smbb charger by default")
Signed-off-by: Rayyan Ansari <[email protected]>
---
arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-common.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-common.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-common.dtsi
index 525d8c608b06..8839b23fc693 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-common.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-common.dtsi
@@ -287,6 +287,10 @@ &sdhc_2 {
status = "okay";
};

+&smbb {
+ status = "okay";
+};
+
&usb {
extcon = <&smbb>;
dr_mode = "peripheral";
--
2.44.0



2024-04-24 20:18:34

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: qcom: msm8226-microsoft-common: Enable smbb explicitly



On 4/24/24 19:42, Rayyan Ansari wrote:
> Enable the smbb node explicitly for MSM8x26 Lumia devices. These devices
> rely on the smbb driver in order to detect USB state.
>
> It seems that this was accidentally missed in the commit that this
> fixes.
>
> Fixes: c9c8179d0ccd ("ARM: dts: qcom: Disable pm8941 & pm8226 smbb charger by default")
> Signed-off-by: Rayyan Ansari <[email protected]>
> ---

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

2024-05-27 03:07:23

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: qcom: msm8226-microsoft-common: Enable smbb explicitly


On Wed, 24 Apr 2024 18:42:06 +0100, Rayyan Ansari wrote:
> Enable the smbb node explicitly for MSM8x26 Lumia devices. These devices
> rely on the smbb driver in order to detect USB state.
>
> It seems that this was accidentally missed in the commit that this
> fixes.
>
>
> [...]

Applied, thanks!

[1/1] ARM: dts: qcom: msm8226-microsoft-common: Enable smbb explicitly
commit: 81a0a21b6159c6a9ed1e39c23e755cd05a102ce3

Best regards,
--
Bjorn Andersson <[email protected]>