On 11/18/2017 07:02 AM, Yang Shi wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by TIPC at all.
>
> So, remove the unused hardirq.h.
>
> Signed-off-by: Yang Shi <[email protected]>
> Cc: Jon Maloy <[email protected]>
> Cc: Ying Xue <[email protected]>
> Cc: "David S. Miller" <[email protected]>
Tested-by: Ying Xue <[email protected]>
Acked-by: Ying Xue <[email protected]>
> ---
> net/tipc/core.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/tipc/core.h b/net/tipc/core.h
> index 5cc5398..099e072 100644
> --- a/net/tipc/core.h
> +++ b/net/tipc/core.h
> @@ -49,7 +49,6 @@
> #include <linux/uaccess.h>
> #include <linux/interrupt.h>
> #include <linux/atomic.h>
> -#include <asm/hardirq.h>
> #include <linux/netdevice.h>
> #include <linux/in.h>
> #include <linux/list.h>
>
Hi David,
Any more comment on this change?
Thanks,
Yang
On 12/7/17 5:40 PM, Ying Xue wrote:
> On 11/18/2017 07:02 AM, Yang Shi wrote:
>> Preempt counter APIs have been split out, currently, hardirq.h just
>> includes irq_enter/exit APIs which are not used by TIPC at all.
>>
>> So, remove the unused hardirq.h.
>>
>> Signed-off-by: Yang Shi <[email protected]>
>> Cc: Jon Maloy <[email protected]>
>> Cc: Ying Xue <[email protected]>
>> Cc: "David S. Miller" <[email protected]>
>
> Tested-by: Ying Xue <[email protected]>
> Acked-by: Ying Xue <[email protected]>
>
>> ---
>> net/tipc/core.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/net/tipc/core.h b/net/tipc/core.h
>> index 5cc5398..099e072 100644
>> --- a/net/tipc/core.h
>> +++ b/net/tipc/core.h
>> @@ -49,7 +49,6 @@
>> #include <linux/uaccess.h>
>> #include <linux/interrupt.h>
>> #include <linux/atomic.h>
>> -#include <asm/hardirq.h>
>> #include <linux/netdevice.h>
>> #include <linux/in.h>
>> #include <linux/list.h>
>>
From: "Yang Shi" <[email protected]>
Date: Fri, 05 Jan 2018 06:46:48 +0800
> Any more comment on this change?
These patches were not really submitted properly.
If you post a series, the series goes to one destination and
one tree.
If they are supposed to go to multiple trees, submit them
individually rather than as a series. With clear indications
in the Subject lines which tree should be taking the patch.
Thank you.
On 1/5/18 7:17 AM, David Miller wrote:
> From: "Yang Shi" <[email protected]>
> Date: Fri, 05 Jan 2018 06:46:48 +0800
>
>> Any more comment on this change?
>
> These patches were not really submitted properly.
>
> If you post a series, the series goes to one destination and
> one tree.
>
> If they are supposed to go to multiple trees, submit them
> individually rather than as a series. With clear indications
> in the Subject lines which tree should be taking the patch.
Thanks for the comment. I will resend the net patches in a separate
series to you.
Yang
>
> Thank you.
>