2019-01-25 02:01:43

by Marcos Paulo de Souza

[permalink] [raw]
Subject: [PATCH] blk-cgroup: Fix doc related to blkcg_exit_queue

Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to
a newly created function called blk_exit_queue, including the call of
blkcg_exit_queue. So, adjust the documenation according.

Signed-off-by: Marcos Paulo de Souza <[email protected]>
---
block/blk-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 2bed5725aa03..77f37ef8ef06 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -1269,7 +1269,7 @@ void blkcg_drain_queue(struct request_queue *q)
* blkcg_exit_queue - exit and release blkcg part of request_queue
* @q: request_queue being released
*
- * Called from blk_release_queue(). Responsible for exiting blkcg part.
+ * Called from blk_exit_queue(). Responsible for exiting blkcg part.
*/
void blkcg_exit_queue(struct request_queue *q)
{
--
2.16.4



2019-01-25 03:50:47

by Bart Van Assche

[permalink] [raw]
Subject: Re: [PATCH] blk-cgroup: Fix doc related to blkcg_exit_queue

On 1/24/19 6:01 PM, Marcos Paulo de Souza wrote:
> Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to
> a newly created function called blk_exit_queue, including the call of
> blkcg_exit_queue. So, adjust the documenation according.
>
> Signed-off-by: Marcos Paulo de Souza <[email protected]>
> ---
> block/blk-cgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
> index 2bed5725aa03..77f37ef8ef06 100644
> --- a/block/blk-cgroup.c
> +++ b/block/blk-cgroup.c
> @@ -1269,7 +1269,7 @@ void blkcg_drain_queue(struct request_queue *q)
> * blkcg_exit_queue - exit and release blkcg part of request_queue
> * @q: request_queue being released
> *
> - * Called from blk_release_queue(). Responsible for exiting blkcg part.
> + * Called from blk_exit_queue(). Responsible for exiting blkcg part.
> */
> void blkcg_exit_queue(struct request_queue *q)
> {

Reviewed-by: Bart Van Assche <[email protected]>

2019-02-09 18:33:52

by Marcos Paulo de Souza

[permalink] [raw]
Subject: Re: [PATCH] blk-cgroup: Fix doc related to blkcg_exit_queue

Ping :)

On 1/25/19 1:50 AM, Bart Van Assche wrote:
> On 1/24/19 6:01 PM, Marcos Paulo de Souza wrote:
>> Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to
>> a newly created function called blk_exit_queue, including the call of
>> blkcg_exit_queue. So, adjust the documenation according.
>>
>> Signed-off-by: Marcos Paulo de Souza <[email protected]>
>> ---
>>   block/blk-cgroup.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
>> index 2bed5725aa03..77f37ef8ef06 100644
>> --- a/block/blk-cgroup.c
>> +++ b/block/blk-cgroup.c
>> @@ -1269,7 +1269,7 @@ void blkcg_drain_queue(struct request_queue *q)
>>    * blkcg_exit_queue - exit and release blkcg part of request_queue
>>    * @q: request_queue being released
>>    *
>> - * Called from blk_release_queue().  Responsible for exiting blkcg part.
>> + * Called from blk_exit_queue().  Responsible for exiting blkcg part.
>>    */
>>   void blkcg_exit_queue(struct request_queue *q)
>>   {
>
> Reviewed-by: Bart Van Assche <[email protected]>


Attachments:
pEpkey.asc (1.77 kB)

2019-02-10 15:25:06

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] blk-cgroup: Fix doc related to blkcg_exit_queue

On 1/24/19 7:01 PM, Marcos Paulo de Souza wrote:
> Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to
> a newly created function called blk_exit_queue, including the call of
> blkcg_exit_queue. So, adjust the documenation according.

Applied, thanks.

--
Jens Axboe