On 20/11/2023 11:02, yu-chang.lee wrote:
> For MT8188, VPPSYS0 and VPPSYS1 are 2 display pipes with
> hardware differences in power domains, clocks and subsystem counts,
> which should be probed from mtk-mmsys driver to populate device by
> platform_device_register_data then start its own clock driver.
>
> Signed-off-by: yu-chang.lee <[email protected]>
> ---
> Change in v4:
> - Squashed binding patches
> - This patch is based on [1]
> [1] soc: mediatek: mmsys: Add support for MT8188 VPPSYS
> - https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
>
This probably should stay part of previous patchset. Why splitting it?
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Mon, 2023-11-20 at 11:09 +0100, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 20/11/2023 11:02, yu-chang.lee wrote:
> > For MT8188, VPPSYS0 and VPPSYS1 are 2 display pipes with
> > hardware differences in power domains, clocks and subsystem counts,
> > which should be probed from mtk-mmsys driver to populate device by
> > platform_device_register_data then start its own clock driver.
> >
> > Signed-off-by: yu-chang.lee <[email protected]>
> > ---
> > Change in v4:
> > - Squashed binding patches
> > - This patch is based on [1]
> > [1] soc: mediatek: mmsys: Add support for MT8188 VPPSYS
> > -
> https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
> >
>
> This probably should stay part of previous patchset. Why splitting
> it?
>
>
> Acked-by: Krzysztof Kozlowski <[email protected]>
>
> Best regards,
> Krzysztof
>
Thank you for your time and effort. I misunderstood that you want me to
send the binding patches as a independent serie in previous discussion.
Only until now I squashed them, but the driver patch has already been
submitted... Should I resend all of these pathes as a serie again?
Thanks,
Best Regards,
yuchang
Il 20/11/23 11:26, Yu-chang Lee (李禹璋) ha scritto:
> On Mon, 2023-11-20 at 11:09 +0100, Krzysztof Kozlowski wrote:
>>
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>> On 20/11/2023 11:02, yu-chang.lee wrote:
>>> For MT8188, VPPSYS0 and VPPSYS1 are 2 display pipes with
>>> hardware differences in power domains, clocks and subsystem counts,
>>> which should be probed from mtk-mmsys driver to populate device by
>>> platform_device_register_data then start its own clock driver.
>>>
>>> Signed-off-by: yu-chang.lee <[email protected]>
>>> ---
>>> Change in v4:
>>> - Squashed binding patches
>>> - This patch is based on [1]
>>> [1] soc: mediatek: mmsys: Add support for MT8188 VPPSYS
>>> -
>> https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
>>>
>>
>> This probably should stay part of previous patchset. Why splitting
>> it?
>>
>>
>> Acked-by: Krzysztof Kozlowski <[email protected]>
>>
>> Best regards,
>> Krzysztof
>>
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
> Thank you for your time and effort. I misunderstood that you want me to
> send the binding patches as a independent serie in previous discussion.
> Only until now I squashed them, but the driver patch has already been
> submitted... Should I resend all of these pathes as a serie again?
>
For this time it's okay, I can pick those separately... but for the next time,
please, yes, the two are related so they should go in one series.
Thanks,
Angelo
> Thanks,
>
> Best Regards,
> yuchang