2023-01-11 19:53:10

by Sohil Mehta

Subject: [PATCH] x86/vsyscall: Fix documentation to reflect the default mode

The default vsyscall mode has been updated from emulate to xonly for a
while. Update the kernel-parameters doc to reflect that.

Fixes: 625b7b7f79c6 ("x86/vsyscall: Change the default vsyscall mode to xonly")
Cc: Andy Lutomirski <[email protected]>
Signed-off-by: Sohil Mehta <[email protected]>
Reviewed-by: Tony Luck <[email protected]>
---
Do documentation fixes typically get backported to stable? I haven't included
a stable cc assuming they do not.

Documentation/admin-guide/kernel-parameters.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 6cfa6e3996cf..87f0b645922c 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -6756,11 +6756,11 @@
functions are at fixed addresses, they make nice
targets for exploits that can control RIP.

- emulate [default] Vsyscalls turn into traps and are
- emulated reasonably safely. The vsyscall
- page is readable.
+ emulate Vsyscalls turn into traps and are emulated
+ reasonably safely. The vsyscall page is
+ readable.

- xonly Vsyscalls turn into traps and are
+ xonly [default] Vsyscalls turn into traps and are
emulated reasonably safely. The vsyscall
page is not readable.

--
2.34.1

2023-01-12 21:50:52

by Kees Cook

Subject: Re: [PATCH] x86/vsyscall: Fix documentation to reflect the default mode

On Wed, Jan 11, 2023 at 07:32:11PM +0000, Sohil Mehta wrote:
> The default vsyscall mode has been updated from emulate to xonly for a
> while. Update the kernel-parameters doc to reflect that.
>
> Fixes: 625b7b7f79c6 ("x86/vsyscall: Change the default vsyscall mode to xonly")
> Cc: Andy Lutomirski <[email protected]>
> Signed-off-by: Sohil Mehta <[email protected]>

Reviewed-by: Kees Cook <[email protected]>

--
Kees Cook

2023-01-19 21:58:12

by Jonathan Corbet

Subject: Re: [PATCH] x86/vsyscall: Fix documentation to reflect the default mode

Sohil Mehta <[email protected]> writes:

> The default vsyscall mode has been updated from emulate to xonly for a
> while. Update the kernel-parameters doc to reflect that.
>
> Fixes: 625b7b7f79c6 ("x86/vsyscall: Change the default vsyscall mode to xonly")
> Cc: Andy Lutomirski <[email protected]>
> Signed-off-by: Sohil Mehta <[email protected]>
> Reviewed-by: Tony Luck <[email protected]>
> ---
> Do documentation fixes typically get backported to stable? I haven't included
> a stable cc assuming they do not.
>
> Documentation/admin-guide/kernel-parameters.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

jon

2023-01-21 17:05:21

by Andy Lutomirski

Subject: Re: [PATCH] x86/vsyscall: Fix documentation to reflect the default mode

On Thu, Jan 19, 2023, at 1:24 PM, Jonathan Corbet wrote:
> Sohil Mehta <[email protected]> writes:
>
>> The default vsyscall mode has been updated from emulate to xonly for a
>> while. Update the kernel-parameters doc to reflect that.
>>
>> Fixes: 625b7b7f79c6 ("x86/vsyscall: Change the default vsyscall mode to xonly")
>> Cc: Andy Lutomirski <[email protected]>
>> Signed-off-by: Sohil Mehta <[email protected]>
>> Reviewed-by: Tony Luck <[email protected]>
>> ---
>> Do documentation fixes typically get backported to stable? I haven't included
>> a stable cc assuming they do not.
>>
>> Documentation/admin-guide/kernel-parameters.txt | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Applied, thanks.

Belated ack! Sohil, thanks for the fix.

>
> jon