2023-01-07 12:42:32

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH] clk: qcom: camcc-sm6350: Make camcc_sm6350_hws static

There's no reason for it not to be static, and some compilers don't
like not it being that way. Make it so.

Reported-by: kernel test robot <[email protected]>
Fixes: 80f5451d9a7c ("clk: qcom: Add camera clock controller driver for SM6350")
Signed-off-by: Konrad Dybcio <[email protected]>
---
drivers/clk/qcom/camcc-sm6350.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/camcc-sm6350.c b/drivers/clk/qcom/camcc-sm6350.c
index ea8600530046..acba9f99d960 100644
--- a/drivers/clk/qcom/camcc-sm6350.c
+++ b/drivers/clk/qcom/camcc-sm6350.c
@@ -1742,7 +1742,7 @@ static struct gdsc titan_top_gdsc = {
.pwrsts = PWRSTS_OFF_ON,
};

-struct clk_hw *camcc_sm6350_hws[] = {
+static struct clk_hw *camcc_sm6350_hws[] = {
[CAMCC_PLL2_OUT_EARLY] = &camcc_pll2_out_early.hw,
};

--
2.39.0


2023-01-11 19:50:00

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: qcom: camcc-sm6350: Make camcc_sm6350_hws static

Quoting Konrad Dybcio (2023-01-07 04:04:34)
> There's no reason for it not to be static, and some compilers don't
> like not it being that way. Make it so.
>
> Reported-by: kernel test robot <[email protected]>
> Fixes: 80f5451d9a7c ("clk: qcom: Add camera clock controller driver for SM6350")
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2023-01-11 19:54:26

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] clk: qcom: camcc-sm6350: Make camcc_sm6350_hws static

On Sat, 7 Jan 2023 13:04:34 +0100, Konrad Dybcio wrote:
> There's no reason for it not to be static, and some compilers don't
> like not it being that way. Make it so.
>
>

Applied, thanks!

[1/1] clk: qcom: camcc-sm6350: Make camcc_sm6350_hws static
commit: bfc7486991c2b1b514cee90854af0f90c56b6bf2

Best regards,
--
Bjorn Andersson <[email protected]>