2024-01-11 13:26:42

by Uladzislau Rezki

Subject: [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag

The vmap_init_free_space() function is called only once
therefore tag it with __init. Apart of that it access the
"vmlist" variable that is located in ".init.data" section.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Fixes: 86817057732 ("mm: vmalloc: remove global vmap_area_root rb-tree")
Signed-off-by: Uladzislau Rezki (Sony) <[email protected]>
---
mm/vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 43a6608e1397..257981e37936 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -4834,7 +4834,7 @@ module_init(proc_vmalloc_init);

#endif

-static void vmap_init_free_space(void)
+static void __init vmap_init_free_space(void)
{
unsigned long vmap_start = 1;
const unsigned long vmap_end = ULONG_MAX;
--
2.39.2

2024-01-11 16:17:07

by Christoph Hellwig

Subject: Re: [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2024-01-16 22:25:39

by Lorenzo Stoakes

Subject: Re: [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag

On Thu, Jan 11, 2024 at 02:26:28PM +0100, Uladzislau Rezki (Sony) wrote:
> The vmap_init_free_space() function is called only once
> therefore tag it with __init. Apart of that it access the
> "vmlist" variable that is located in ".init.data" section.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 86817057732 ("mm: vmalloc: remove global vmap_area_root rb-tree")
> Signed-off-by: Uladzislau Rezki (Sony) <[email protected]>
> ---
> mm/vmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 43a6608e1397..257981e37936 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -4834,7 +4834,7 @@ module_init(proc_vmalloc_init);
>
> #endif
>
> -static void vmap_init_free_space(void)
> +static void __init vmap_init_free_space(void)
> {
> unsigned long vmap_start = 1;
> const unsigned long vmap_end = ULONG_MAX;
> --
> 2.39.2
>

Looks good to me too. Feel free to add:

Reviewed-by: Lorenzo Stoakes <[email protected]>

2024-01-17 06:08:52

by Anshuman Khandual

Subject: Re: [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag

On 1/11/24 18:56, Uladzislau Rezki (Sony) wrote:
> The vmap_init_free_space() function is called only once
> therefore tag it with __init. Apart of that it access the
> "vmlist" variable that is located in ".init.data" section.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 86817057732 ("mm: vmalloc: remove global vmap_area_root rb-tree")
> Signed-off-by: Uladzislau Rezki (Sony) <[email protected]>
> ---
> mm/vmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 43a6608e1397..257981e37936 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -4834,7 +4834,7 @@ module_init(proc_vmalloc_init);
>
> #endif
>
> -static void vmap_init_free_space(void)
> +static void __init vmap_init_free_space(void)
> {
> unsigned long vmap_start = 1;
> const unsigned long vmap_end = ULONG_MAX;

LGTM

Reviewed-by: Anshuman Khandual <[email protected]>