2023-05-25 13:00:55

by Baolin Wang

Subject: [PATCH 0/6] Misc cleanups and improvements for compaction

Hi,

This series cantains some cleanups and improvements for compaction.
Please help to review. Thanks.

Baolin Wang (6):
mm: compaction: drop the redundant page validation in
update_pageblock_skip()
mm: compaction: change fast_isolate_freepages() to void type
mm: compaction: skip more fully scanned pageblock
mm: compaction: only set skip flag if cc->no_set_skip_hint is false
mm: compaction: add trace event for fast freepages isolation
mm: compaction: skip fast freepages isolation if enough freepages are
isolated

include/trace/events/compaction.h | 11 +++++++++++
mm/compaction.c | 25 ++++++++++++++-----------
2 files changed, 25 insertions(+), 11 deletions(-)

--
2.27.0

2023-05-25 13:01:42

by Baolin Wang

Subject: [PATCH 2/6] mm: compaction: change fast_isolate_freepages() to void type

No caller cares about the return value of fast_isolate_freepages(),
void it.

Signed-off-by: Baolin Wang <[email protected]>
---
mm/compaction.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 426bb6ce070b..3737c6591bfb 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1435,8 +1435,7 @@ static int next_search_order(struct compact_control *cc, int order)
return order;
}

-static unsigned long
-fast_isolate_freepages(struct compact_control *cc)
+static void fast_isolate_freepages(struct compact_control *cc)
{
unsigned int limit = max(1U, freelist_scan_limit(cc) >> 1);
unsigned int nr_scanned = 0;
@@ -1449,7 +1448,7 @@ fast_isolate_freepages(struct compact_control *cc)

/* Full compaction passes in a negative order */
if (cc->order <= 0)
- return cc->free_pfn;
+ return;

/*
* If starting the scan, use a deeper search and use the highest
@@ -1588,11 +1587,10 @@ fast_isolate_freepages(struct compact_control *cc)

cc->total_free_scanned += nr_scanned;
if (!page)
- return cc->free_pfn;
+ return;

low_pfn = page_to_pfn(page);
fast_isolate_around(cc, low_pfn);
- return low_pfn;
}

/*
--
2.27.0

2023-05-30 07:39:20

by Vlastimil Babka

Subject: Re: [PATCH 2/6] mm: compaction: change fast_isolate_freepages() to void type

On 5/25/23 14:53, Baolin Wang wrote:
> No caller cares about the return value of fast_isolate_freepages(),
> void it.
>
> Signed-off-by: Baolin Wang <[email protected]>

Acked-by: Vlastimil Babka <[email protected]>