2006-09-04 08:46:46

by Aubrey Li

Subject: [PATCH] Fill more device IDS in the structure of m25p80 driver

Hi all,

the structure:
struct flash_info __devinitdata m25p_data [] = {
/* REVISIT: fill in JEDEC ids, for parts that have them */
...
};

has a bunch of missing fields (like the JEDEC ids indicated) ... this
causes problems when actually trying to use some ST parts as it gets
detected incorrectly

The following is the patch.
----------------------------------------------------------------------
Signed-off-by: Aubrey L1 <[email protected]>
---

* Fill more device IDS in the structure of m25p80 driver.
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index a846614..ef4a731 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -406,13 +406,13 @@ struct flash_info {

static struct flash_info __devinitdata m25p_data [] = {
/* REVISIT: fill in JEDEC ids, for parts that have them */
- { "m25p05", 0x05, 0x0000, 32 * 1024, 2 },
- { "m25p10", 0x10, 0x0000, 32 * 1024, 4 },
- { "m25p20", 0x11, 0x0000, 64 * 1024, 4 },
- { "m25p40", 0x12, 0x0000, 64 * 1024, 8 },
+ { "m25p05", 0x05, 0x2010, 32 * 1024, 2 },
+ { "m25p10", 0x10, 0x2011, 32 * 1024, 4 },
+ { "m25p20", 0x11, 0x2012, 64 * 1024, 4 },
+ { "m25p40", 0x12, 0x2013, 64 * 1024, 8 },
{ "m25p80", 0x13, 0x0000, 64 * 1024, 16 },
- { "m25p16", 0x14, 0x0000, 64 * 1024, 32 },
- { "m25p32", 0x15, 0x0000, 64 * 1024, 64 },
+ { "m25p16", 0x14, 0x2015, 64 * 1024, 32 },
+ { "m25p32", 0x15, 0x2016, 64 * 1024, 64 },
{ "m25p64", 0x16, 0x2017, 64 * 1024, 128 },
};

Regards,
-Aubrey

--
VGER BF report: H 0.283918

2006-09-04 13:06:04

by Josh Boyer

Subject: Re: [PATCH] Fill more device IDS in the structure of m25p80 driver

On 9/4/06, Aubrey <[email protected]> wrote:
> Hi all,
>
> the structure:
> struct flash_info __devinitdata m25p_data [] = {
> /* REVISIT: fill in JEDEC ids, for parts that have them */
> ...
> };
>
> has a bunch of missing fields (like the JEDEC ids indicated) ... this
> causes problems when actually trying to use some ST parts as it gets
> detected incorrectly
>
> The following is the patch.

The patch appears to have corrupted whitespace. Your mailer probably
mangled it. Care to try and fix it and resend?

thx,
josh