From: Daniele Palmas <[email protected]>
[ Upstream commit e0ae2c578d3909e60e9448207f5d83f785f1129f ]
This patch adds support for Telit FN980 0x1050 composition
0x1050: tty, adb, rmnet, tty, tty, tty, tty
Signed-off-by: Daniele Palmas <[email protected]>
Acked-by: Bjørn Mork <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/net/usb/qmi_wwan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index e406a05e79dcd..57e9166b4bff3 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1252,6 +1252,7 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
{QMI_FIXED_INTF(0x2357, 0x9000, 4)}, /* TP-LINK MA260 */
{QMI_QUIRK_SET_DTR(0x1bc7, 0x1040, 2)}, /* Telit LE922A */
+ {QMI_QUIRK_SET_DTR(0x1bc7, 0x1050, 2)}, /* Telit FN980 */
{QMI_FIXED_INTF(0x1bc7, 0x1100, 3)}, /* Telit ME910 */
{QMI_FIXED_INTF(0x1bc7, 0x1101, 3)}, /* Telit ME910 dual modem */
{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
--
2.20.1
Hi,
On Sat, Oct 26, 2019 at 3:27 PM Sasha Levin <[email protected]> wrote:
>
> From: Daniele Palmas <[email protected]>
>
> [ Upstream commit e0ae2c578d3909e60e9448207f5d83f785f1129f ]
>
> This patch adds support for Telit FN980 0x1050 composition
>
> 0x1050: tty, adb, rmnet, tty, tty, tty, tty
>
> Signed-off-by: Daniele Palmas <[email protected]>
> Acked-by: Bjørn Mork <[email protected]>
> Signed-off-by: Jakub Kicinski <[email protected]>
> Signed-off-by: Sasha Levin <[email protected]>
> ---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index e406a05e79dcd..57e9166b4bff3 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1252,6 +1252,7 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
> {QMI_FIXED_INTF(0x2357, 0x9000, 4)}, /* TP-LINK MA260 */
> {QMI_QUIRK_SET_DTR(0x1bc7, 0x1040, 2)}, /* Telit LE922A */
> + {QMI_QUIRK_SET_DTR(0x1bc7, 0x1050, 2)}, /* Telit FN980 */
> {QMI_FIXED_INTF(0x1bc7, 0x1100, 3)}, /* Telit ME910 */
> {QMI_FIXED_INTF(0x1bc7, 0x1101, 3)}, /* Telit ME910 dual modem */
> {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
> --
> 2.20.1
>
When testing the FN980 with kernel 4.14, I noticed that the qmi device
was not there. Checking the git log, I see that this patch was never
applied. The patch applies fine, so I guess it was just missed
somewhere. If it could be added to the next 4.14 release, it would be
much appreciated.
BR,
Kristian
On Mon, Sep 07, 2020 at 11:36:37AM +0200, Kristian Evensen wrote:
>Hi,
>
>On Sat, Oct 26, 2019 at 3:27 PM Sasha Levin <[email protected]> wrote:
>>
>> From: Daniele Palmas <[email protected]>
>>
>> [ Upstream commit e0ae2c578d3909e60e9448207f5d83f785f1129f ]
>>
>> This patch adds support for Telit FN980 0x1050 composition
>>
>> 0x1050: tty, adb, rmnet, tty, tty, tty, tty
>>
>> Signed-off-by: Daniele Palmas <[email protected]>
>> Acked-by: Bj?rn Mork <[email protected]>
>> Signed-off-by: Jakub Kicinski <[email protected]>
>> Signed-off-by: Sasha Levin <[email protected]>
>> ---
>> drivers/net/usb/qmi_wwan.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
>> index e406a05e79dcd..57e9166b4bff3 100644
>> --- a/drivers/net/usb/qmi_wwan.c
>> +++ b/drivers/net/usb/qmi_wwan.c
>> @@ -1252,6 +1252,7 @@ static const struct usb_device_id products[] = {
>> {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
>> {QMI_FIXED_INTF(0x2357, 0x9000, 4)}, /* TP-LINK MA260 */
>> {QMI_QUIRK_SET_DTR(0x1bc7, 0x1040, 2)}, /* Telit LE922A */
>> + {QMI_QUIRK_SET_DTR(0x1bc7, 0x1050, 2)}, /* Telit FN980 */
>> {QMI_FIXED_INTF(0x1bc7, 0x1100, 3)}, /* Telit ME910 */
>> {QMI_FIXED_INTF(0x1bc7, 0x1101, 3)}, /* Telit ME910 dual modem */
>> {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
>> --
>> 2.20.1
>>
>
>When testing the FN980 with kernel 4.14, I noticed that the qmi device
>was not there. Checking the git log, I see that this patch was never
>applied. The patch applies fine, so I guess it was just missed
>somewhere. If it could be added to the next 4.14 release, it would be
>much appreciated.
Interesting, yes - I'm not sure why it's missing. I'll queue it up.
--
Thanks,
Sasha
On 9/8/2020 01:15, Sasha Levin wrote:
> On Mon, Sep 07, 2020 at 11:36:37AM +0200, Kristian Evensen wrote:
// snip
>> When testing the FN980 with kernel 4.14, I noticed that the qmi device
>> was not there. Checking the git log, I see that this patch was never
>> applied. The patch applies fine, so I guess it was just missed
>> somewhere. If it could be added to the next 4.14 release, it would be
>> much appreciated.
>
> Interesting, yes - I'm not sure why it's missing. I'll queue it up.
>
The patch is missing from all 4.x LTS kernels, not only 4.14
br
Lars
On Tue, Sep 08, 2020 at 07:33:21AM +0700, Lars Melin wrote:
>On 9/8/2020 01:15, Sasha Levin wrote:
>>On Mon, Sep 07, 2020 at 11:36:37AM +0200, Kristian Evensen wrote:
>// snip
>
>>>When testing the FN980 with kernel 4.14, I noticed that the qmi device
>>>was not there. Checking the git log, I see that this patch was never
>>>applied. The patch applies fine, so I guess it was just missed
>>>somewhere. If it could be added to the next 4.14 release, it would be
>>>much appreciated.
>>
>>Interesting, yes - I'm not sure why it's missing. I'll queue it up.
>>
>
>The patch is missing from all 4.x LTS kernels, not only 4.14
Right, it's queued up for all the trees.
--
Thanks,
Sasha