2023-09-12 14:53:45

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [PATCH v4] mtd: rawnand: qcom: Unmap the right resource upon probe failure

On Tue, Sep 12, 2023 at 08:02:07PM +0530, Bibek Kumar Patro wrote:
>
>
> On 9/12/2023 5:58 PM, Miquel Raynal wrote:
> > > We currently provide the physical address of the DMA region
> > > rather than the output of dma_map_resource() which is obviously wrong.
> > >
> > > Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
> > Cc: stable?
> Cc: [email protected]

You need to send another version adding the CC tag.

With the tag added,

Reviewed-by: Manivannan Sadhasivam <[email protected]>

- Mani

--
மணிவண்ணன் சதாசிவம்


2023-09-13 11:53:14

by Bibek Kumar Patro

[permalink] [raw]
Subject: Re: [PATCH v4] mtd: rawnand: qcom: Unmap the right resource upon probe failure



On 9/12/2023 8:07 PM, Manivannan Sadhasivam wrote:
> On Tue, Sep 12, 2023 at 08:02:07PM +0530, Bibek Kumar Patro wrote:
>>
>>
>> On 9/12/2023 5:58 PM, Miquel Raynal wrote:
>>>> We currently provide the physical address of the DMA region
>>>> rather than the output of dma_map_resource() which is obviously wrong.
>>>>
>>>> Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
>>> Cc: stable?
>> Cc: [email protected]
>
> You need to send another version adding the CC tag.

Sure Mani, sent a new patch with cc tag. Addressed in v5 patchset.

>
> With the tag added,
>
> Reviewed-by: Manivannan Sadhasivam <[email protected]>
>

Added in v5 patch.

> - Mani
>

Thanks & regards,
Bibek