2022-03-10 02:05:13

by Sang Min Kim

[permalink] [raw]
Subject: [PATCH 3/3] thermal: samsung: Update makefile for artpec8

 
Add makefile changes for axis artpec8 driver.
 
Signed-off-by: sangmin kim <[email protected]>
---
 drivers/thermal/samsung/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 
diff --git a/drivers/thermal/samsung/Makefile b/drivers/thermal/samsung/Makefile
index f139407..c9e9a33 100644
--- a/drivers/thermal/samsung/Makefile
+++ b/drivers/thermal/samsung/Makefile
@@ -3,4 +3,4 @@
 # Samsung thermal specific Makefile
 #
 obj-$(CONFIG_EXYNOS_THERMAL)                        += exynos_thermal.o
-exynos_thermal-y                                := exynos_tmu.o
+exynos_thermal-y                                := artpec8_tmu.o exynos_tmu.o
-- 
2.9.5
 
 


2022-03-10 14:53:30

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 3/3] thermal: samsung: Update makefile for artpec8

On 10/03/2022 02:57, Sang Min Kim wrote:
>  

You have wrong formatting of commit messages. Using git helps a lot to
create proper patches.

> Add makefile changes for axis artpec8 driver.
>  

Why this is separate? This means before you added a C file which cannot
be compiled?

> Signed-off-by: sangmin kim <[email protected]>
> ---
>  drivers/thermal/samsung/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>  

Best regards,
Krzysztof