Currently the enabled MMC controllers on Pine H64 do not have bus-width
set, which make them fall back to 1-bit mode and become quite slow.
Fix this by add the corresponding bus-width properties.
Fixes: ecbd611882a1 ("arm64: allwinner: h6: enable MMC0/2 on Pine H64")
Signed-off-by: Icenowy Zheng <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
index ceffc40810ee..48daec7f78ba 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts
@@ -46,6 +46,7 @@
pinctrl-0 = <&mmc0_pins>;
vmmc-supply = <®_cldo1>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
+ bus-width = <4>;
status = "okay";
};
@@ -56,6 +57,7 @@
vqmmc-supply = <®_bldo2>;
non-removable;
cap-mmc-hw-reset;
+ bus-width = <8>;
status = "okay";
};
--
2.18.0
On Thu, Jul 26, 2018 at 12:48:05PM +0800, Icenowy Zheng wrote:
> Currently the enabled MMC controllers on Pine H64 do not have bus-width
> set, which make them fall back to 1-bit mode and become quite slow.
>
> Fix this by add the corresponding bus-width properties.
>
> Fixes: ecbd611882a1 ("arm64: allwinner: h6: enable MMC0/2 on Pine H64")
> Signed-off-by: Icenowy Zheng <[email protected]>
Applied, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
在 2018-07-30一的 10:27 +0200，Maxime Ripard写道：
> On Thu, Jul 26, 2018 at 12:48:05PM +0800, Icenowy Zheng wrote:
> > Currently the enabled MMC controllers on Pine H64 do not have bus-
> > width
> > set, which make them fall back to 1-bit mode and become quite slow.
> >
> > Fix this by add the corresponding bus-width properties.
> >
> > Fixes: ecbd611882a1 ("arm64: allwinner: h6: enable MMC0/2 on Pine
> > H64")
> > Signed-off-by: Icenowy Zheng <[email protected]>
>
> Applied, thanks!
BTW why didn't I see it in next-20180820?
It's 3 weeks later, and you didn't say that the patch is queued for
another version.
> Maxime
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Mon, Aug 20, 2018 at 10:24:20PM +0800, Icenowy Zheng wrote:
> 在 2018-07-30一的 10:27 +0200，Maxime Ripard写道：
> > On Thu, Jul 26, 2018 at 12:48:05PM +0800, Icenowy Zheng wrote:
> > > Currently the enabled MMC controllers on Pine H64 do not have bus-
> > > width
> > > set, which make them fall back to 1-bit mode and become quite slow.
> > >
> > > Fix this by add the corresponding bus-width properties.
> > >
> > > Fixes: ecbd611882a1 ("arm64: allwinner: h6: enable MMC0/2 on Pine
> > > H64")
> > > Signed-off-by: Icenowy Zheng <[email protected]>
> >
> > Applied, thanks!
>
> BTW why didn't I see it in next-20180820?
>
> It's 3 weeks later, and you didn't say that the patch is queued for
> another version.
This has been merged to a fix branch we'll send for 4.19 once rc1 is
out.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com