I am not subscribed to the list, please CC me directly.
Fix the following warnings (6 total):WARNING: drivers/isdn/hisax/hisax.o(.text+0x9c5): Section mismatch inreference from the function HiSax_inithardware() to the function.devinit.text:hisax_cs_setup_card()The function HiSax_inithardware() referencesthe function __devinit hisax_cs_setup_card().This is often because HiSax_inithardware lacks a __devinitannotation or the annotation of hisax_cs_setup_card is wrong.
WARNING: drivers/isdn/hisax/hisax.o(.text+0xb45): Section mismatch inreference from the function hisax_init_pcmcia() to the function.devinit.text:hisax_cs_setup_card()The function hisax_init_pcmcia() referencesthe function __devinit hisax_cs_setup_card().This is often because hisax_init_pcmcia lacks a __devinitannotation or the annotation of hisax_cs_setup_card is wrong.
Signed-off-by: Vlada Peri? <vlada.peric <at> gmail.com>Cc: Karsten Keil <kkeil <at> suse.de>Cc: Kai Germaschewski <kai.germaschewski <at> gmx.de>--- drivers/isdn/hisax/config.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.cindex 84d75a3..db2aebc 100644--- a/drivers/isdn/hisax/config.c+++ b/drivers/isdn/hisax/config.c@@ -1213,7 +1213,7 @@ static void HiSax_shiftcards(int idx) memcpy(&cards[i], &cards[i + 1], sizeof(cards[i])); }
-static int HiSax_inithardware(int *busy_flag)+static int __devinit HiSax_inithardware(int *busy_flag) { int foundcards = 0; int i = 0;@@ -1542,7 +1542,7 @@ static void __exit HiSax_exit(void) printk(KERN_INFO "HiSax module removed\n"); }
-int hisax_init_pcmcia(void *pcm_iob, int *busy_flag, struct IsdnCard *card)+int __devinit hisax_init_pcmcia(void *pcm_iob, int *busy_flag, structIsdnCard *card) { u_char ids[16]; int ret = -1;-- 1.6.0.3????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
On Sun, Oct 26, 2008 at 09:25:25PM +0100, Vlada Peric wrote:
> -static int HiSax_inithardware(int *busy_flag)
> +static int __devinit HiSax_inithardware(int *busy_flag)
> -int hisax_init_pcmcia(void *pcm_iob, int *busy_flag, struct IsdnCard *card)
> +int __devinit hisax_init_pcmcia(void *pcm_iob, int *busy_flag, struct
Let's remove __devinit, not spread it.
Alexey, who honestly tried to fix all section mismatches
on fatconfig and miserably failed because after ISDN
part took like 90% of resulting patch and the question
whether root annotations are correct in the first place
became louder and louder.