2018-09-28 12:47:11

by Tianyu Lan

Subject: [PATCH] KVM/VMX: Remve unused function is_external_interrupt().

is_external_interrupt() is not used now and so remove it.

Signed-off-by: Lan Tianyu <[email protected]>
---
arch/x86/kvm/vmx.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 70e1f916bfc9..619307b3e6bb 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -1667,12 +1667,6 @@ static inline bool is_gp_fault(u32 intr_info)
return is_exception_n(intr_info, GP_VECTOR);
}

-static inline bool is_external_interrupt(u32 intr_info)
-{
- return (intr_info & (INTR_INFO_INTR_TYPE_MASK | INTR_INFO_VALID_MASK))
- == (INTR_TYPE_EXT_INTR | INTR_INFO_VALID_MASK);
-}
-
static inline bool is_machine_check(u32 intr_info)
{
return (intr_info & (INTR_INFO_INTR_TYPE_MASK | INTR_INFO_VECTOR_MASK |
--
2.14.4

2018-10-01 14:01:21

by Paolo Bonzini

Subject: Re: [PATCH] KVM/VMX: Remve unused function is_external_interrupt().

On 28/09/2018 14:45, Tianyu Lan wrote:
> is_external_interrupt() is not used now and so remove it.
>
> Signed-off-by: Lan Tianyu <[email protected]>
> ---
> arch/x86/kvm/vmx.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 70e1f916bfc9..619307b3e6bb 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -1667,12 +1667,6 @@ static inline bool is_gp_fault(u32 intr_info)
> return is_exception_n(intr_info, GP_VECTOR);
> }
>
> -static inline bool is_external_interrupt(u32 intr_info)
> -{
> - return (intr_info & (INTR_INFO_INTR_TYPE_MASK | INTR_INFO_VALID_MASK))
> - == (INTR_TYPE_EXT_INTR | INTR_INFO_VALID_MASK);
> -}
> -
> static inline bool is_machine_check(u32 intr_info)
> {
> return (intr_info & (INTR_INFO_INTR_TYPE_MASK | INTR_INFO_VECTOR_MASK |
>

Queued, thanks.

Paolo