On 6/9/21 9:26 AM, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail() in ssh_request_layer.c.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Baokun Li <[email protected]>
Looks good to me, thanks!
Reviewed-by: Maximilian Luz <[email protected]>
Regards,
Max
> ---
> V1->V2:
> CC mailist
>
> .../surface/aggregator/ssh_request_layer.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/surface/aggregator/ssh_request_layer.c b/drivers/platform/surface/aggregator/ssh_request_layer.c
> index 52a83a8fcf82..fec2d7af2646 100644
> --- a/drivers/platform/surface/aggregator/ssh_request_layer.c
> +++ b/drivers/platform/surface/aggregator/ssh_request_layer.c
> @@ -863,9 +863,7 @@ static void ssh_rtl_timeout_reap(struct work_struct *work)
> clear_bit(SSH_REQUEST_SF_PENDING_BIT, &r->state);
>
> atomic_dec(&rtl->pending.count);
> - list_del(&r->node);
> -
> - list_add_tail(&r->node, &claimed);
> + list_move_tail(&r->node, &claimed);
> }
> spin_unlock(&rtl->pending.lock);
>
> @@ -1204,8 +1202,7 @@ void ssh_rtl_shutdown(struct ssh_rtl *rtl)
> smp_mb__before_atomic();
> clear_bit(SSH_REQUEST_SF_QUEUED_BIT, &r->state);
>
> - list_del(&r->node);
> - list_add_tail(&r->node, &claimed);
> + list_move_tail(&r->node, &claimed);
> }
> spin_unlock(&rtl->queue.lock);
>
> @@ -1238,8 +1235,7 @@ void ssh_rtl_shutdown(struct ssh_rtl *rtl)
> smp_mb__before_atomic();
> clear_bit(SSH_REQUEST_SF_PENDING_BIT, &r->state);
>
> - list_del(&r->node);
> - list_add_tail(&r->node, &claimed);
> + list_move_tail(&r->node, &claimed);
> }
> spin_unlock(&rtl->pending.lock);
> }
>