2017-10-19 01:35:03

by Tao Wang

[permalink] [raw]
Subject: Re: [PATCH] thermal/drivers/hisi: disable multi alarm support for hi3660 SoC



在 2017/10/18 23:54, Daniel Lezcano 写道:
> On 18/10/2017 11:15, Tao Wang wrote:
>> From: Kevin Wangtao <[email protected]>
>>
>> multi alarm interrupt forced a re-trigger of power_allocator_throttle
>> which changes the PID's actual sampling rate, this isn't optimal for
>> IPA, it is best to disable multi alarm support now and sort out this
>> issue later.
>>
>> Signed-off-by: Kevin Wangtao <[email protected]>
>
> Did you test the series with this change?
Yes
>
>> ---
>> drivers/thermal/hisi_thermal.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
>> index 133238a..3b74c12 100644
>> --- a/drivers/thermal/hisi_thermal.c
>> +++ b/drivers/thermal/hisi_thermal.c
>> @@ -360,7 +360,6 @@ static int hi3660_thermal_enable_sensor(struct hisi_thermal_data *data)
>>
>> /* set interrupt threshold */
>> value = hi3660_thermal_temp_to_step(sensor->thres_temp[0]);
>> - value |= hi3660_thermal_temp_to_step(sensor->thres_temp[1]) << 10;
>> hi3660_thermal_alarm_set(data->regs, sensor->id, value);
>>
>> /* enable interrupt */
>>
>
>


From 1581611354772880382@xxx Wed Oct 18 15:55:27 +0000 2017
X-GM-THRID: 1581602208642488418
X-Gmail-Labels: Inbox,Category Forums