2023-12-06 16:02:33

by Sean Nyekjaer

[permalink] [raw]
Subject: [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define

Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
DSA_TAG_PROTO_LAN937X to improve readability.

Signed-off-by: Sean Nyekjaer <[email protected]>
---
Changes since v1:
- removed Fixes tag

drivers/net/dsa/microchip/ksz_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 286e20f340e5..5c2214784ed0 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -2614,7 +2614,7 @@ static enum dsa_tag_protocol ksz_get_tag_protocol(struct dsa_switch *ds,
proto = DSA_TAG_PROTO_KSZ9477;

if (is_lan937x(dev))
- proto = DSA_TAG_PROTO_LAN937X_VALUE;
+ proto = DSA_TAG_PROTO_LAN937X;

return proto;
}
--
2.42.0


2023-12-06 16:08:28

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define

On Wed, Dec 06, 2023 at 05:01:23PM +0100, Sean Nyekjaer wrote:
> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> DSA_TAG_PROTO_LAN937X to improve readability.
>
> Signed-off-by: Sean Nyekjaer <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2023-12-07 04:12:45

by Arun Ramadoss

[permalink] [raw]
Subject: Re: [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define


On Wed, 2023-12-06 at 17:01 +0100, Sean Nyekjaer wrote:
> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> DSA_TAG_PROTO_LAN937X to improve readability.
>
> Signed-off-by: Sean Nyekjaer <[email protected]>

Acked-by: Arun Ramadoss <[email protected]>

2023-12-08 19:10:32

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH v2 net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Wed, 6 Dec 2023 17:01:23 +0100 you wrote:
> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> DSA_TAG_PROTO_LAN937X to improve readability.
>
> Signed-off-by: Sean Nyekjaer <[email protected]>
> ---
> Changes since v1:
> - removed Fixes tag
>
> [...]

Here is the summary with links:
- [v2,net-next] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE define
https://git.kernel.org/netdev/net-next/c/cf02bea7c171

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html