2020-09-07 17:16:11

by Wang Hai

Subject: [PATCH -next] blktrace: make function blk_trace_bio_get_cgid() static

The sparse tool complains as follows:

kernel/trace/blktrace.c:796:5: warning:
symbol 'blk_trace_bio_get_cgid' was not declared. Should it be static?

This function is not used outside of blktrace.c, so this commit
marks it static.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wang Hai <[email protected]>
---
kernel/trace/blktrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 4b3a42fc3b24..c0887f32f647 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -793,7 +793,7 @@ static u64 blk_trace_bio_get_cgid(struct request_queue *q, struct bio *bio)
return cgroup_id(bio_blkcg(bio)->css.cgroup);
}
#else
-u64 blk_trace_bio_get_cgid(struct request_queue *q, struct bio *bio)
+static u64 blk_trace_bio_get_cgid(struct request_queue *q, struct bio *bio)
{
return 0;
}
--
2.17.1

2020-09-07 19:44:35

by Jens Axboe

Subject: Re: [PATCH -next] blktrace: make function blk_trace_bio_get_cgid() static

On 9/7/20 8:06 AM, Wang Hai wrote:
> The sparse tool complains as follows:
>
> kernel/trace/blktrace.c:796:5: warning:
> symbol 'blk_trace_bio_get_cgid' was not declared. Should it be static?
>
> This function is not used outside of blktrace.c, so this commit
> marks it static.

Applied, thanks.

--
Jens Axboe