2020-05-07 03:23:55

by Zou Wei

[permalink] [raw]

Subject: [PATCH -next] drm/ast: Make ast_primary_plane_helper_atomic_update static

---

Fix the following sparse warning:

drivers/gpu/drm/ast/ast_mode.c:564:6: warning:
symbol 'ast_primary_plane_helper_atomic_update'
was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Samuel Zou <[email protected]>
---
drivers/gpu/drm/ast/ast_mode.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 7062bcd..4ddf770 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -561,8 +561,9 @@ static int ast_primary_plane_helper_atomic_check(struct drm_plane *plane,
return 0;
}

-void ast_primary_plane_helper_atomic_update(struct drm_plane *plane,
- struct drm_plane_state *old_state)
+static void
+ast_primary_plane_helper_atomic_update(struct drm_plane *plane,
+ struct drm_plane_state *old_state)
{
struct ast_private *ast = plane->dev->dev_private;
struct drm_plane_state *state = plane->state;
--
2.6.2

2020-05-08 06:46:16

by Thomas Zimmermann

[permalink] [raw]

Subject: Re: [PATCH -next] drm/ast: Make ast_primary_plane_helper_atomic_update static

---

I'll add your patch to drm-misc-next. Thanks!

Am 07.05.20 um 04:40 schrieb Samuel Zou:
> Fix the following sparse warning:
>
> drivers/gpu/drm/ast/ast_mode.c:564:6: warning:
> symbol 'ast_primary_plane_helper_atomic_update'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Samuel Zou <[email protected]>

Reviewed-by: Thomas Zimmermann <[email protected]>

> ---
> drivers/gpu/drm/ast/ast_mode.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 7062bcd..4ddf770 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -561,8 +561,9 @@ static int ast_primary_plane_helper_atomic_check(struct drm_plane *plane,
> return 0;
> }
>
> -void ast_primary_plane_helper_atomic_update(struct drm_plane *plane,
> - struct drm_plane_state *old_state)
> +static void
> +ast_primary_plane_helper_atomic_update(struct drm_plane *plane,
> + struct drm_plane_state *old_state)
> {
> struct ast_private *ast = plane->dev->dev_private;
> struct drm_plane_state *state = plane->state;
>

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

---

Attachments:

signature.asc (499.00 B)
OpenPGP digital signature